[FlexJS] Anyone working on the build problems?

classic Classic list List threaded Threaded
18 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[FlexJS] Anyone working on the build problems?

Christofer Dutz
Hi,

For the last 4 days the build of FlexJS framework has been failing while compiling the Examples … is anyone working on this? I would like to have a green build again asap. The compiler is sort of returning an error code of “3” … if that rings any bells.

Chris
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [FlexJS] Anyone working on the build problems?

Peter Ent
I didn't think the build, built the examples. If that's the case, I'll
build the examples and see what fails and then exclude those from the
build and work on them to get them running again.
‹peter

On 3/26/17, 11:30 AM, "Christofer Dutz" <[hidden email]> wrote:

>Hi,
>
>For the last 4 days the build of FlexJS framework has been failing while
>compiling the Examples Š is anyone working on this? I would like to have
>a green build again asap. The compiler is sort of returning an error code
>of ³3² Š if that rings any bells.
>
>Chris

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

AW: [FlexJS] Anyone working on the build problems?

Christofer Dutz
Well that's one of the reasons I setup the build that way, as the compiler error reporting was so poor that a lot of problems only occur in the application compilation - as it seems to be in this case too. It also tests that the examples produce a runnable application that works in the browser.

Nevertheless the official Jenkins is red for four days now, this should have been an indicator that there are still problems.

Chris



Von meinem Samsung Galaxy Smartphone gesendet.


-------- Ursprüngliche Nachricht --------
Von: Peter Ent <[hidden email]>
Datum: 26.03.17 17:34 (GMT+01:00)
An: [hidden email]
Betreff: Re: [FlexJS] Anyone working on the build problems?

I didn't think the build, built the examples. If that's the case, I'll
build the examples and see what fails and then exclude those from the
build and work on them to get them running again.
‹peter

On 3/26/17, 11:30 AM, "Christofer Dutz" <[hidden email]> wrote:

>Hi,
>
>For the last 4 days the build of FlexJS framework has been failing while
>compiling the Examples Š is anyone working on this? I would like to have
>a green build again asap. The compiler is sort of returning an error code
>of ³3² Š if that rings any bells.
>
>Chris

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [FlexJS] Anyone working on the build problems?

piotrz
In reply to this post by Christofer Dutz
Hi Chris,

I did check this one and explain it in the other thread.

Maven build still failing cause in folder Basic/target (stays after
previous build) one file with unproved license. - It happened since Basic has been removed from maven build.

How to perform on Basic module - clean without building ? - It will remove target folder from Basic and resolve
problem.

Other option - add Basic to exclude of rat list.

Piotr
Apache Flex PMC
piotrzarzycki21@gmail.com
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [FlexJS] Anyone working on the build problems?

Christofer Dutz
Hi Piotr,

Well, all I did was to click on “cleanup workspace” and do another build and then that problem went away and the commit problem came. I am also getting the build errors when building locally.

Sorry for not following most of the threads here … as you can imagine it has been a busy week with my duties for Tac and preparing the Summit.

Chris



Am 26.03.17, 20:12 schrieb "piotrz" <[hidden email]>:

    Hi Chris,
   
    I did check this one and explain it in the other thread.
   
    Maven build still failing cause in folder Basic/target (stays after
    previous build) one file with unproved license. - It happened since Basic
    has been removed from maven build.
   
    How to perform on Basic module - clean without building ? - It will remove
    target folder from Basic and resolve
    problem.
   
    Other option - add Basic to exclude of rat list.
   
    Piotr
   
   
   
    -----
    Apache Flex PMC
    [hidden email]
    --
    View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-Anyone-working-on-the-build-problems-tp60777p60785.html
    Sent from the Apache Flex Development mailing list archive at Nabble.com.
   

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [FlexJS] Anyone working on the build problems?

piotrz
Thanks Chris!

No problem - I'm pasting here stack trace [1] - maybe someone will take a look. I don't know what is happen.

[1] https://paste.apache.org/g6Jj

Piotr
Apache Flex PMC
piotrzarzycki21@gmail.com
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [FlexJS] Anyone working on the build problems?

Harbs
Have you pulled in the latest changes for Falcon?

> On Mar 26, 2017, at 10:54 PM, piotrz <[hidden email]> wrote:
>
> Thanks Chris!
>
> No problem - I'm pasting here stack trace [1] - maybe someone will take a
> look. I don't know what is happen.
>
> [1] https://paste.apache.org/g6Jj
>
> Piotr
>
>
>
> -----
> Apache Flex PMC
> [hidden email]
> --
> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-Anyone-working-on-the-build-problems-tp60777p60787.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [FlexJS] Anyone working on the build problems?

piotrz
Hi Harbs,

This is stack trace is straight from jenkins build.

Locally I have same fail and definitely I did build with fresh sources of Falcon.

Piotr
Apache Flex PMC
piotrzarzycki21@gmail.com
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [FlexJS] Anyone working on the build problems?

Harbs
I’m also having trouble building, but it’s failing at a totally different place.

> On Mar 26, 2017, at 11:08 PM, piotrz <[hidden email]> wrote:
>
> Hi Harbs,
>
> This is stack trace is straight from jenkins build.
>
> Locally I have same fail and definitely I did build with fresh sources of
> Falcon.
>
> Piotr
>
>
>
> -----
> Apache Flex PMC
> [hidden email]
> --
> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-Anyone-working-on-the-build-problems-tp60777p60789.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [FlexJS] Anyone working on the build problems?

Harbs
There seemed to be three things causing me build problems:
1. compiler-jx/src/test/java/org/apache/flex/compiler/internal/test/FlexJSTestBase.java A reference to frameworks/as/basic-manifest.xml which does not seem to exist.
2. compiler-jx/src/test/java/org/apache/flex/compiler/internal/codegen/mxml/sourcemaps/TestSourceMapMXMLScript.java The tests are failing.
3. compiler-jx/src/test/java/org/apache/flex/compiler/internal/codegen/mxml/sourcemaps/TestSourceMapMXMLEvents.java The tests are failing.

Removing the test in 1 and the latter two files allowed Falcon and asjs to build on my machine.

Harbs

> On Mar 26, 2017, at 11:26 PM, Harbs <[hidden email]> wrote:
>
> I’m also having trouble building, but it’s failing at a totally different place.
>
>> On Mar 26, 2017, at 11:08 PM, piotrz <[hidden email]> wrote:
>>
>> Hi Harbs,
>>
>> This is stack trace is straight from jenkins build.
>>
>> Locally I have same fail and definitely I did build with fresh sources of
>> Falcon.
>>
>> Piotr
>>
>>
>>
>> -----
>> Apache Flex PMC
>> [hidden email]
>> --
>> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-Anyone-working-on-the-build-problems-tp60777p60789.html
>> Sent from the Apache Flex Development mailing list archive at Nabble.com.
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [FlexJS] Anyone working on the build problems?

Harbs
I’m now getting a similar error when compiling a test project.

> On Mar 26, 2017, at 11:53 PM, Harbs <[hidden email]> wrote:
>
> There seemed to be three things causing me build problems:
> 1. compiler-jx/src/test/java/org/apache/flex/compiler/internal/test/FlexJSTestBase.java A reference to frameworks/as/basic-manifest.xml which does not seem to exist.
> 2. compiler-jx/src/test/java/org/apache/flex/compiler/internal/codegen/mxml/sourcemaps/TestSourceMapMXMLScript.java The tests are failing.
> 3. compiler-jx/src/test/java/org/apache/flex/compiler/internal/codegen/mxml/sourcemaps/TestSourceMapMXMLEvents.java The tests are failing.
>
> Removing the test in 1 and the latter two files allowed Falcon and asjs to build on my machine.
>
> Harbs
>
>> On Mar 26, 2017, at 11:26 PM, Harbs <[hidden email]> wrote:
>>
>> I’m also having trouble building, but it’s failing at a totally different place.
>>
>>> On Mar 26, 2017, at 11:08 PM, piotrz <[hidden email]> wrote:
>>>
>>> Hi Harbs,
>>>
>>> This is stack trace is straight from jenkins build.
>>>
>>> Locally I have same fail and definitely I did build with fresh sources of
>>> Falcon.
>>>
>>> Piotr
>>>
>>>
>>>
>>> -----
>>> Apache Flex PMC
>>> [hidden email]
>>> --
>>> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-Anyone-working-on-the-build-problems-tp60777p60789.html
>>> Sent from the Apache Flex Development mailing list archive at Nabble.com.
>>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [FlexJS] Anyone working on the build problems?

Josh Tynjala
In reply to this post by Harbs
1. I don't think this part is actually an issue (other than being annoying
noise in the output). I also see this warning and my build finishes
successfully.

2/3. I think these new tests that I wrote rely on flex-asjs in some way
(since they're parsing MXML), and maybe it's having trouble finding that
project on your machine. I'll see if I can move them to the correct part of
the build where it runs the optional "dependent" tests.

- Josh

On Sun, Mar 26, 2017 at 1:53 PM, Harbs <[hidden email]> wrote:

> There seemed to be three things causing me build problems:
> 1. compiler-jx/src/test/java/org/apache/flex/compiler/internal/test/FlexJSTestBase.java
> A reference to frameworks/as/basic-manifest.xml which does not seem to
> exist.
> 2. compiler-jx/src/test/java/org/apache/flex/compiler/internal/
> codegen/mxml/sourcemaps/TestSourceMapMXMLScript.java The tests are
> failing.
> 3. compiler-jx/src/test/java/org/apache/flex/compiler/internal/
> codegen/mxml/sourcemaps/TestSourceMapMXMLEvents.java The tests are
> failing.
>
> Removing the test in 1 and the latter two files allowed Falcon and asjs to
> build on my machine.
>
> Harbs
>
> > On Mar 26, 2017, at 11:26 PM, Harbs <[hidden email]> wrote:
> >
> > I’m also having trouble building, but it’s failing at a totally
> different place.
> >
> >> On Mar 26, 2017, at 11:08 PM, piotrz <[hidden email]> wrote:
> >>
> >> Hi Harbs,
> >>
> >> This is stack trace is straight from jenkins build.
> >>
> >> Locally I have same fail and definitely I did build with fresh sources
> of
> >> Falcon.
> >>
> >> Piotr
> >>
> >>
> >>
> >> -----
> >> Apache Flex PMC
> >> [hidden email]
> >> --
> >> View this message in context: http://apache-flex-
> development.2333347.n4.nabble.com/FlexJS-Anyone-working-on-
> the-build-problems-tp60777p60789.html
> >> Sent from the Apache Flex Development mailing list archive at
> Nabble.com.
> >
>
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [FlexJS] Anyone working on the build problems?

Christofer Dutz
Hi Josh,

Tests shouldn’t require a directory structure … especially not outside of the current maven modules directory. This type of refactoring is what consumed most of my time while migrating Falcon from Ant to Maven. Having a look at the current problem, it seems the problems are related to its dependency to FlexJSTestBase, which seems to require a set of environment variables and expects other directories. This dependency to framework would have introduced a cycle, which is also the reason I couldn’t refactor the tests without completely re-writing most of them.

We should address the FlexJsTestBase tests and make sure we are able to test what they should be testing without introducing a cyclic dependency.

For now, excluding them from the testsuite is probably the best option.

Chris


Am 26.03.17, 23:19 schrieb "Josh Tynjala" <[hidden email]>:

    1. I don't think this part is actually an issue (other than being annoying
    noise in the output). I also see this warning and my build finishes
    successfully.
   
    2/3. I think these new tests that I wrote rely on flex-asjs in some way
    (since they're parsing MXML), and maybe it's having trouble finding that
    project on your machine. I'll see if I can move them to the correct part of
    the build where it runs the optional "dependent" tests.
   
    - Josh
   
    On Sun, Mar 26, 2017 at 1:53 PM, Harbs <[hidden email]> wrote:
   
    > There seemed to be three things causing me build problems:
    > 1. compiler-jx/src/test/java/org/apache/flex/compiler/internal/test/FlexJSTestBase.java
    > A reference to frameworks/as/basic-manifest.xml which does not seem to
    > exist.
    > 2. compiler-jx/src/test/java/org/apache/flex/compiler/internal/
    > codegen/mxml/sourcemaps/TestSourceMapMXMLScript.java The tests are
    > failing.
    > 3. compiler-jx/src/test/java/org/apache/flex/compiler/internal/
    > codegen/mxml/sourcemaps/TestSourceMapMXMLEvents.java The tests are
    > failing.
    >
    > Removing the test in 1 and the latter two files allowed Falcon and asjs to
    > build on my machine.
    >
    > Harbs
    >
    > > On Mar 26, 2017, at 11:26 PM, Harbs <[hidden email]> wrote:
    > >
    > > I’m also having trouble building, but it’s failing at a totally
    > different place.
    > >
    > >> On Mar 26, 2017, at 11:08 PM, piotrz <[hidden email]> wrote:
    > >>
    > >> Hi Harbs,
    > >>
    > >> This is stack trace is straight from jenkins build.
    > >>
    > >> Locally I have same fail and definitely I did build with fresh sources
    > of
    > >> Falcon.
    > >>
    > >> Piotr
    > >>
    > >>
    > >>
    > >> -----
    > >> Apache Flex PMC
    > >> [hidden email]
    > >> --
    > >> View this message in context: http://apache-flex-
    > development.2333347.n4.nabble.com/FlexJS-Anyone-working-on-
    > the-build-problems-tp60777p60789.html
    > >> Sent from the Apache Flex Development mailing list archive at
    > Nabble.com.
    > >
    >
    >
   

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [FlexJS] Anyone working on the build problems?

Josh Tynjala
I didn't structure the tests this way. I followed the existing tests that
were already there.

- Josh

On Mar 27, 2017 1:04 AM, "Christofer Dutz" <[hidden email]>
wrote:

> Hi Josh,
>
> Tests shouldn’t require a directory structure … especially not outside of
> the current maven modules directory. This type of refactoring is what
> consumed most of my time while migrating Falcon from Ant to Maven. Having a
> look at the current problem, it seems the problems are related to its
> dependency to FlexJSTestBase, which seems to require a set of environment
> variables and expects other directories. This dependency to framework would
> have introduced a cycle, which is also the reason I couldn’t refactor the
> tests without completely re-writing most of them.
>
> We should address the FlexJsTestBase tests and make sure we are able to
> test what they should be testing without introducing a cyclic dependency.
>
> For now, excluding them from the testsuite is probably the best option.
>
> Chris
>
>
> Am 26.03.17, 23:19 schrieb "Josh Tynjala" <[hidden email]>:
>
>     1. I don't think this part is actually an issue (other than being
> annoying
>     noise in the output). I also see this warning and my build finishes
>     successfully.
>
>     2/3. I think these new tests that I wrote rely on flex-asjs in some way
>     (since they're parsing MXML), and maybe it's having trouble finding
> that
>     project on your machine. I'll see if I can move them to the correct
> part of
>     the build where it runs the optional "dependent" tests.
>
>     - Josh
>
>     On Sun, Mar 26, 2017 at 1:53 PM, Harbs <[hidden email]> wrote:
>
>     > There seemed to be three things causing me build problems:
>     > 1. compiler-jx/src/test/java/org/apache/flex/compiler/internal/
> test/FlexJSTestBase.java
>     > A reference to frameworks/as/basic-manifest.xml which does not seem
> to
>     > exist.
>     > 2. compiler-jx/src/test/java/org/apache/flex/compiler/internal/
>     > codegen/mxml/sourcemaps/TestSourceMapMXMLScript.java The tests are
>     > failing.
>     > 3. compiler-jx/src/test/java/org/apache/flex/compiler/internal/
>     > codegen/mxml/sourcemaps/TestSourceMapMXMLEvents.java The tests are
>     > failing.
>     >
>     > Removing the test in 1 and the latter two files allowed Falcon and
> asjs to
>     > build on my machine.
>     >
>     > Harbs
>     >
>     > > On Mar 26, 2017, at 11:26 PM, Harbs <[hidden email]> wrote:
>     > >
>     > > I’m also having trouble building, but it’s failing at a totally
>     > different place.
>     > >
>     > >> On Mar 26, 2017, at 11:08 PM, piotrz <[hidden email]>
> wrote:
>     > >>
>     > >> Hi Harbs,
>     > >>
>     > >> This is stack trace is straight from jenkins build.
>     > >>
>     > >> Locally I have same fail and definitely I did build with fresh
> sources
>     > of
>     > >> Falcon.
>     > >>
>     > >> Piotr
>     > >>
>     > >>
>     > >>
>     > >> -----
>     > >> Apache Flex PMC
>     > >> [hidden email]
>     > >> --
>     > >> View this message in context: http://apache-flex-
>     > development.2333347.n4.nabble.com/FlexJS-Anyone-working-on-
>     > the-build-problems-tp60777p60789.html
>     > >> Sent from the Apache Flex Development mailing list archive at
>     > Nabble.com.
>     > >
>     >
>     >
>
>
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [FlexJS] Anyone working on the build problems?

Christofer Dutz
Hi Josh,

I guess in that case it was one of the tests which I excluded from the Maven build … so if you add another it will automatically be run, as Maven doesn’t know it should exclude it. If you have a look in the pom.xml you will see the surefire plugin (runs unit tests) and the failsafe plugin (runs integration tests). Here a hand full of tests are excluded because they need a refactoring to not introduce a cycle or need to be moved to the framework module (I would prefer the first option)

Guess it would be cool if we figured out a way to refactor the tests so we can run them in Maven … eventually doing so over a beer in Miami would be a good invest of time? What do you think ;-)

Chris

Am 27.03.17, 17:43 schrieb "Josh Tynjala" <[hidden email]>:

    I didn't structure the tests this way. I followed the existing tests that
    were already there.
   
    - Josh
   
    On Mar 27, 2017 1:04 AM, "Christofer Dutz" <[hidden email]>
    wrote:
   
    > Hi Josh,
    >
    > Tests shouldn’t require a directory structure … especially not outside of
    > the current maven modules directory. This type of refactoring is what
    > consumed most of my time while migrating Falcon from Ant to Maven. Having a
    > look at the current problem, it seems the problems are related to its
    > dependency to FlexJSTestBase, which seems to require a set of environment
    > variables and expects other directories. This dependency to framework would
    > have introduced a cycle, which is also the reason I couldn’t refactor the
    > tests without completely re-writing most of them.
    >
    > We should address the FlexJsTestBase tests and make sure we are able to
    > test what they should be testing without introducing a cyclic dependency.
    >
    > For now, excluding them from the testsuite is probably the best option.
    >
    > Chris
    >
    >
    > Am 26.03.17, 23:19 schrieb "Josh Tynjala" <[hidden email]>:
    >
    >     1. I don't think this part is actually an issue (other than being
    > annoying
    >     noise in the output). I also see this warning and my build finishes
    >     successfully.
    >
    >     2/3. I think these new tests that I wrote rely on flex-asjs in some way
    >     (since they're parsing MXML), and maybe it's having trouble finding
    > that
    >     project on your machine. I'll see if I can move them to the correct
    > part of
    >     the build where it runs the optional "dependent" tests.
    >
    >     - Josh
    >
    >     On Sun, Mar 26, 2017 at 1:53 PM, Harbs <[hidden email]> wrote:
    >
    >     > There seemed to be three things causing me build problems:
    >     > 1. compiler-jx/src/test/java/org/apache/flex/compiler/internal/
    > test/FlexJSTestBase.java
    >     > A reference to frameworks/as/basic-manifest.xml which does not seem
    > to
    >     > exist.
    >     > 2. compiler-jx/src/test/java/org/apache/flex/compiler/internal/
    >     > codegen/mxml/sourcemaps/TestSourceMapMXMLScript.java The tests are
    >     > failing.
    >     > 3. compiler-jx/src/test/java/org/apache/flex/compiler/internal/
    >     > codegen/mxml/sourcemaps/TestSourceMapMXMLEvents.java The tests are
    >     > failing.
    >     >
    >     > Removing the test in 1 and the latter two files allowed Falcon and
    > asjs to
    >     > build on my machine.
    >     >
    >     > Harbs
    >     >
    >     > > On Mar 26, 2017, at 11:26 PM, Harbs <[hidden email]> wrote:
    >     > >
    >     > > I’m also having trouble building, but it’s failing at a totally
    >     > different place.
    >     > >
    >     > >> On Mar 26, 2017, at 11:08 PM, piotrz <[hidden email]>
    > wrote:
    >     > >>
    >     > >> Hi Harbs,
    >     > >>
    >     > >> This is stack trace is straight from jenkins build.
    >     > >>
    >     > >> Locally I have same fail and definitely I did build with fresh
    > sources
    >     > of
    >     > >> Falcon.
    >     > >>
    >     > >> Piotr
    >     > >>
    >     > >>
    >     > >>
    >     > >> -----
    >     > >> Apache Flex PMC
    >     > >> [hidden email]
    >     > >> --
    >     > >> View this message in context: http://apache-flex-
    >     > development.2333347.n4.nabble.com/FlexJS-Anyone-working-on-
    >     > the-build-problems-tp60777p60789.html
    >     > >> Sent from the Apache Flex Development mailing list archive at
    >     > Nabble.com.
    >     > >
    >     >
    >     >
    >
    >
    >
   

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [FlexJS] Anyone working on the build problems?

Josh Tynjala
Yes, after the Maven build failed, I saw that the other MXML tests were
excluded, and I excluded my new ones in the same place. The Maven side has
no problems with my changes anymore. Just gotta tweak the Ant build a bit.

If we find the time to come up with better tests in Miami, that would be
cool.

I have some ideas for how to run my new tests without the asjs dependency.
Basically, it involves creating a couple of custom AS/MXML classes to
reference in MXML instead of real components from the framework. The exact
classes referenced in MXML don't matter for my tests. It was simply
convenient to follow the patterns of the existing tests to get it written
quickly. These custom classes could probably be used to improve some of
those other tests too.

- Josh

On Mar 27, 2017 1:04 PM, "Christofer Dutz" <[hidden email]>
wrote:

Hi Josh,

I guess in that case it was one of the tests which I excluded from the
Maven build … so if you add another it will automatically be run, as Maven
doesn’t know it should exclude it. If you have a look in the pom.xml you
will see the surefire plugin (runs unit tests) and the failsafe plugin
(runs integration tests). Here a hand full of tests are excluded because
they need a refactoring to not introduce a cycle or need to be moved to the
framework module (I would prefer the first option)

Guess it would be cool if we figured out a way to refactor the tests so we
can run them in Maven … eventually doing so over a beer in Miami would be a
good invest of time? What do you think ;-)

Chris

Am 27.03.17, 17:43 schrieb "Josh Tynjala" <[hidden email]>:

    I didn't structure the tests this way. I followed the existing tests
that
    were already there.

    - Josh

    On Mar 27, 2017 1:04 AM, "Christofer Dutz" <[hidden email]>
    wrote:

    > Hi Josh,
    >
    > Tests shouldn’t require a directory structure … especially not
outside of
    > the current maven modules directory. This type of refactoring is what
    > consumed most of my time while migrating Falcon from Ant to Maven.
Having a
    > look at the current problem, it seems the problems are related to its
    > dependency to FlexJSTestBase, which seems to require a set of
environment
    > variables and expects other directories. This dependency to framework
would
    > have introduced a cycle, which is also the reason I couldn’t refactor
the
    > tests without completely re-writing most of them.
    >
    > We should address the FlexJsTestBase tests and make sure we are able
to
    > test what they should be testing without introducing a cyclic
dependency.
    >
    > For now, excluding them from the testsuite is probably the best
option.
    >
    > Chris
    >
    >
    > Am 26.03.17, 23:19 schrieb "Josh Tynjala" <[hidden email]>:
    >
    >     1. I don't think this part is actually an issue (other than being
    > annoying
    >     noise in the output). I also see this warning and my build
finishes
    >     successfully.
    >
    >     2/3. I think these new tests that I wrote rely on flex-asjs in
some way
    >     (since they're parsing MXML), and maybe it's having trouble
finding
    > that
    >     project on your machine. I'll see if I can move them to the
correct
    > part of
    >     the build where it runs the optional "dependent" tests.
    >
    >     - Josh
    >
    >     On Sun, Mar 26, 2017 at 1:53 PM, Harbs <[hidden email]>
wrote:
    >
    >     > There seemed to be three things causing me build problems:
    >     > 1. compiler-jx/src/test/java/org/apache/flex/compiler/internal/
    > test/FlexJSTestBase.java
    >     > A reference to frameworks/as/basic-manifest.xml which does not
seem
    > to
    >     > exist.
    >     > 2. compiler-jx/src/test/java/org/apache/flex/compiler/internal/
    >     > codegen/mxml/sourcemaps/TestSourceMapMXMLScript.java The tests
are
    >     > failing.
    >     > 3. compiler-jx/src/test/java/org/apache/flex/compiler/internal/
    >     > codegen/mxml/sourcemaps/TestSourceMapMXMLEvents.java The tests
are
    >     > failing.
    >     >
    >     > Removing the test in 1 and the latter two files allowed Falcon
and
    > asjs to
    >     > build on my machine.
    >     >
    >     > Harbs
    >     >
    >     > > On Mar 26, 2017, at 11:26 PM, Harbs <[hidden email]>
wrote:
    >     > >
    >     > > I’m also having trouble building, but it’s failing at a
totally
    >     > different place.
    >     > >
    >     > >> On Mar 26, 2017, at 11:08 PM, piotrz <
[hidden email]>
    > wrote:
    >     > >>
    >     > >> Hi Harbs,
    >     > >>
    >     > >> This is stack trace is straight from jenkins build.
    >     > >>
    >     > >> Locally I have same fail and definitely I did build with
fresh
    > sources
    >     > of
    >     > >> Falcon.
    >     > >>
    >     > >> Piotr
    >     > >>
    >     > >>
    >     > >>
    >     > >> -----
    >     > >> Apache Flex PMC
    >     > >> [hidden email]
    >     > >> --
    >     > >> View this message in context: http://apache-flex-
    >     > development.2333347.n4.nabble.com/FlexJS-Anyone-working-on-
    >     > the-build-problems-tp60777p60789.html
    >     > >> Sent from the Apache Flex Development mailing list archive at
    >     > Nabble.com.
    >     > >
    >     >
    >     >
    >
    >
    >
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [FlexJS] Anyone working on the build problems?

Alex Harui
I have disabled the ListExample and made a few other fixes and the Maven
build is now building the framework and other examples and is now failing
in the IntegrationTests with a Selenium version mismatch error.  Hopefully
Christofer or someone else can figure that out.  I'm going off to do other
things.

Thanks,
-Alex

On 3/27/17, 6:19 PM, "Josh Tynjala" <[hidden email]> wrote:

>Yes, after the Maven build failed, I saw that the other MXML tests were
>excluded, and I excluded my new ones in the same place. The Maven side has
>no problems with my changes anymore. Just gotta tweak the Ant build a bit.
>
>If we find the time to come up with better tests in Miami, that would be
>cool.
>
>I have some ideas for how to run my new tests without the asjs dependency.
>Basically, it involves creating a couple of custom AS/MXML classes to
>reference in MXML instead of real components from the framework. The exact
>classes referenced in MXML don't matter for my tests. It was simply
>convenient to follow the patterns of the existing tests to get it written
>quickly. These custom classes could probably be used to improve some of
>those other tests too.
>
>- Josh
>
>On Mar 27, 2017 1:04 PM, "Christofer Dutz" <[hidden email]>
>wrote:
>
>Hi Josh,
>
>I guess in that case it was one of the tests which I excluded from the
>Maven build … so if you add another it will automatically be run, as Maven
>doesn’t know it should exclude it. If you have a look in the pom.xml you
>will see the surefire plugin (runs unit tests) and the failsafe plugin
>(runs integration tests). Here a hand full of tests are excluded because
>they need a refactoring to not introduce a cycle or need to be moved to
>the
>framework module (I would prefer the first option)
>
>Guess it would be cool if we figured out a way to refactor the tests so we
>can run them in Maven … eventually doing so over a beer in Miami would be
>a
>good invest of time? What do you think ;-)
>
>Chris
>
>Am 27.03.17, 17:43 schrieb "Josh Tynjala" <[hidden email]>:
>
>    I didn't structure the tests this way. I followed the existing tests
>that
>    were already there.
>
>    - Josh
>
>    On Mar 27, 2017 1:04 AM, "Christofer Dutz" <[hidden email]>
>    wrote:
>
>    > Hi Josh,
>    >
>    > Tests shouldn’t require a directory structure … especially not
>outside of
>    > the current maven modules directory. This type of refactoring is
>what
>    > consumed most of my time while migrating Falcon from Ant to Maven.
>Having a
>    > look at the current problem, it seems the problems are related to
>its
>    > dependency to FlexJSTestBase, which seems to require a set of
>environment
>    > variables and expects other directories. This dependency to
>framework
>would
>    > have introduced a cycle, which is also the reason I couldn’t
>refactor
>the
>    > tests without completely re-writing most of them.
>    >
>    > We should address the FlexJsTestBase tests and make sure we are able
>to
>    > test what they should be testing without introducing a cyclic
>dependency.
>    >
>    > For now, excluding them from the testsuite is probably the best
>option.
>    >
>    > Chris
>    >
>    >
>    > Am 26.03.17, 23:19 schrieb "Josh Tynjala" <[hidden email]>:
>    >
>    >     1. I don't think this part is actually an issue (other than
>being
>    > annoying
>    >     noise in the output). I also see this warning and my build
>finishes
>    >     successfully.
>    >
>    >     2/3. I think these new tests that I wrote rely on flex-asjs in
>some way
>    >     (since they're parsing MXML), and maybe it's having trouble
>finding
>    > that
>    >     project on your machine. I'll see if I can move them to the
>correct
>    > part of
>    >     the build where it runs the optional "dependent" tests.
>    >
>    >     - Josh
>    >
>    >     On Sun, Mar 26, 2017 at 1:53 PM, Harbs <[hidden email]>
>wrote:
>    >
>    >     > There seemed to be three things causing me build problems:
>    >     > 1.
>compiler-jx/src/test/java/org/apache/flex/compiler/internal/
>    > test/FlexJSTestBase.java
>    >     > A reference to frameworks/as/basic-manifest.xml which does not
>seem
>    > to
>    >     > exist.
>    >     > 2.
>compiler-jx/src/test/java/org/apache/flex/compiler/internal/
>    >     > codegen/mxml/sourcemaps/TestSourceMapMXMLScript.java The tests
>are
>    >     > failing.
>    >     > 3.
>compiler-jx/src/test/java/org/apache/flex/compiler/internal/
>    >     > codegen/mxml/sourcemaps/TestSourceMapMXMLEvents.java The tests
>are
>    >     > failing.
>    >     >
>    >     > Removing the test in 1 and the latter two files allowed Falcon
>and
>    > asjs to
>    >     > build on my machine.
>    >     >
>    >     > Harbs
>    >     >
>    >     > > On Mar 26, 2017, at 11:26 PM, Harbs <[hidden email]>
>wrote:
>    >     > >
>    >     > > I’m also having trouble building, but it’s failing at a
>totally
>    >     > different place.
>    >     > >
>    >     > >> On Mar 26, 2017, at 11:08 PM, piotrz <
>[hidden email]>
>    > wrote:
>    >     > >>
>    >     > >> Hi Harbs,
>    >     > >>
>    >     > >> This is stack trace is straight from jenkins build.
>    >     > >>
>    >     > >> Locally I have same fail and definitely I did build with
>fresh
>    > sources
>    >     > of
>    >     > >> Falcon.
>    >     > >>
>    >     > >> Piotr
>    >     > >>
>    >     > >>
>    >     > >>
>    >     > >> -----
>    >     > >> Apache Flex PMC
>    >     > >> [hidden email]
>    >     > >> --
>    >     > >> View this message in context: http://apache-flex-
>    >     > development.2333347.n4.nabble.com/FlexJS-Anyone-working-on-
>    >     > the-build-problems-tp60777p60789.html
>    >     > >> Sent from the Apache Flex Development mailing list archive
>at
>    >     > Nabble.com.
>    >     > >
>    >     >
>    >     >
>    >
>    >
>    >

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [FlexJS] Anyone working on the build problems?

Christofer Dutz
Ok … so the problem with the build you reported was due to the fact that the Java version seems to have changed on the agents and I had to re-set it to 1.8.
Now I am getting a failing Integration Test which seems to relate to the store example not working when running it in a browser. So eventually the build now compiles the example, but that particular example has either changed or doesn’t work.

Chris

Am 29.03.17, 06:51 schrieb "Alex Harui" <[hidden email]>:

    I have disabled the ListExample and made a few other fixes and the Maven
    build is now building the framework and other examples and is now failing
    in the IntegrationTests with a Selenium version mismatch error.  Hopefully
    Christofer or someone else can figure that out.  I'm going off to do other
    things.
   
    Thanks,
    -Alex
   
    On 3/27/17, 6:19 PM, "Josh Tynjala" <[hidden email]> wrote:
   
    >Yes, after the Maven build failed, I saw that the other MXML tests were
    >excluded, and I excluded my new ones in the same place. The Maven side has
    >no problems with my changes anymore. Just gotta tweak the Ant build a bit.
    >
    >If we find the time to come up with better tests in Miami, that would be
    >cool.
    >
    >I have some ideas for how to run my new tests without the asjs dependency.
    >Basically, it involves creating a couple of custom AS/MXML classes to
    >reference in MXML instead of real components from the framework. The exact
    >classes referenced in MXML don't matter for my tests. It was simply
    >convenient to follow the patterns of the existing tests to get it written
    >quickly. These custom classes could probably be used to improve some of
    >those other tests too.
    >
    >- Josh
    >
    >On Mar 27, 2017 1:04 PM, "Christofer Dutz" <[hidden email]>
    >wrote:
    >
    >Hi Josh,
    >
    >I guess in that case it was one of the tests which I excluded from the
    >Maven build … so if you add another it will automatically be run, as Maven
    >doesn’t know it should exclude it. If you have a look in the pom.xml you
    >will see the surefire plugin (runs unit tests) and the failsafe plugin
    >(runs integration tests). Here a hand full of tests are excluded because
    >they need a refactoring to not introduce a cycle or need to be moved to
    >the
    >framework module (I would prefer the first option)
    >
    >Guess it would be cool if we figured out a way to refactor the tests so we
    >can run them in Maven … eventually doing so over a beer in Miami would be
    >a
    >good invest of time? What do you think ;-)
    >
    >Chris
    >
    >Am 27.03.17, 17:43 schrieb "Josh Tynjala" <[hidden email]>:
    >
    >    I didn't structure the tests this way. I followed the existing tests
    >that
    >    were already there.
    >
    >    - Josh
    >
    >    On Mar 27, 2017 1:04 AM, "Christofer Dutz" <[hidden email]>
    >    wrote:
    >
    >    > Hi Josh,
    >    >
    >    > Tests shouldn’t require a directory structure … especially not
    >outside of
    >    > the current maven modules directory. This type of refactoring is
    >what
    >    > consumed most of my time while migrating Falcon from Ant to Maven.
    >Having a
    >    > look at the current problem, it seems the problems are related to
    >its
    >    > dependency to FlexJSTestBase, which seems to require a set of
    >environment
    >    > variables and expects other directories. This dependency to
    >framework
    >would
    >    > have introduced a cycle, which is also the reason I couldn’t
    >refactor
    >the
    >    > tests without completely re-writing most of them.
    >    >
    >    > We should address the FlexJsTestBase tests and make sure we are able
    >to
    >    > test what they should be testing without introducing a cyclic
    >dependency.
    >    >
    >    > For now, excluding them from the testsuite is probably the best
    >option.
    >    >
    >    > Chris
    >    >
    >    >
    >    > Am 26.03.17, 23:19 schrieb "Josh Tynjala" <[hidden email]>:
    >    >
    >    >     1. I don't think this part is actually an issue (other than
    >being
    >    > annoying
    >    >     noise in the output). I also see this warning and my build
    >finishes
    >    >     successfully.
    >    >
    >    >     2/3. I think these new tests that I wrote rely on flex-asjs in
    >some way
    >    >     (since they're parsing MXML), and maybe it's having trouble
    >finding
    >    > that
    >    >     project on your machine. I'll see if I can move them to the
    >correct
    >    > part of
    >    >     the build where it runs the optional "dependent" tests.
    >    >
    >    >     - Josh
    >    >
    >    >     On Sun, Mar 26, 2017 at 1:53 PM, Harbs <[hidden email]>
    >wrote:
    >    >
    >    >     > There seemed to be three things causing me build problems:
    >    >     > 1.
    >compiler-jx/src/test/java/org/apache/flex/compiler/internal/
    >    > test/FlexJSTestBase.java
    >    >     > A reference to frameworks/as/basic-manifest.xml which does not
    >seem
    >    > to
    >    >     > exist.
    >    >     > 2.
    >compiler-jx/src/test/java/org/apache/flex/compiler/internal/
    >    >     > codegen/mxml/sourcemaps/TestSourceMapMXMLScript.java The tests
    >are
    >    >     > failing.
    >    >     > 3.
    >compiler-jx/src/test/java/org/apache/flex/compiler/internal/
    >    >     > codegen/mxml/sourcemaps/TestSourceMapMXMLEvents.java The tests
    >are
    >    >     > failing.
    >    >     >
    >    >     > Removing the test in 1 and the latter two files allowed Falcon
    >and
    >    > asjs to
    >    >     > build on my machine.
    >    >     >
    >    >     > Harbs
    >    >     >
    >    >     > > On Mar 26, 2017, at 11:26 PM, Harbs <[hidden email]>
    >wrote:
    >    >     > >
    >    >     > > I’m also having trouble building, but it’s failing at a
    >totally
    >    >     > different place.
    >    >     > >
    >    >     > >> On Mar 26, 2017, at 11:08 PM, piotrz <
    >[hidden email]>
    >    > wrote:
    >    >     > >>
    >    >     > >> Hi Harbs,
    >    >     > >>
    >    >     > >> This is stack trace is straight from jenkins build.
    >    >     > >>
    >    >     > >> Locally I have same fail and definitely I did build with
    >fresh
    >    > sources
    >    >     > of
    >    >     > >> Falcon.
    >    >     > >>
    >    >     > >> Piotr
    >    >     > >>
    >    >     > >>
    >    >     > >>
    >    >     > >> -----
    >    >     > >> Apache Flex PMC
    >    >     > >> [hidden email]
    >    >     > >> --
    >    >     > >> View this message in context: http://apache-flex-
    >    >     > development.2333347.n4.nabble.com/FlexJS-Anyone-working-on-
    >    >     > the-build-problems-tp60777p60789.html
    >    >     > >> Sent from the Apache Flex Development mailing list archive
    >at
    >    >     > Nabble.com.
    >    >     > >
    >    >     >
    >    >     >
    >    >
    >    >
    >    >
   
   

Loading...