[FlexJS] Layout of NumericStepper is broken

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[FlexJS] Layout of NumericStepper is broken

piotrz
Hi,

I just tried NumericStepper on our release branch and it looks horrible. I have following code [1], can someone look into that ? I will raise jira later.



[1] https://paste.apache.org/wbLN

Piotr
Reply | Threaded
Open this post in threaded view
|

Re: [FlexJS] Layout of NumericStepper is broken

Peter Ent-2
I'm looking into it. The SWF and JS versions are different. There's a
border around it, which is specified in the defaults.css. I'm not sure why
that is there; maybe I put it there awhile ago I just don't remember. It
looks better without it.

The SWF version, for me, has some extra graphics in the incrementing
button and the JS version has the buttons just slightly misaligned with
the input field. Running this on macOS Sierra, Safari 10.1.1, Firefox
50.0.3, and Chrome 58.0.3.

on which OS(es) and browser(s) are you seeing this?

‹peter

On 6/5/17, 10:31 AM, "piotrz" <[hidden email]> wrote:

>Hi,
>
>I just tried NumericStepper on our release branch and it looks horrible. I
>have following code [1], can someone look into that ? I will raise jira
>later.
>
><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-fl
>ex-development.2333347.n4.nabble.com%2Ffile%2Fn62108%2Fbroken_numeric_step
>per.png&data=02%7C01%7C%7Cccc8644d5a054e8cd1e508d4ac21a197%7Cfa7b1b5a7b344
>38794aed2c178decee1%7C0%7C0%7C636322707827257340&sdata=uLxglwUpmvJYZRzMtXF
>iAi0W65ytuPaVL1DxfVYBCUo%3D&reserved=0>
>
>[1]
>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpaste.apa
>che.org%2FwbLN&data=02%7C01%7C%7Cccc8644d5a054e8cd1e508d4ac21a197%7Cfa7b1b
>5a7b34438794aed2c178decee1%7C0%7C0%7C636322707827257340&sdata=8wSGQeRReell
>5enJgXlniYVCvf9Jq0OQazKyfksWBdI%3D&reserved=0
>
>Piotr
>
>
>
>-----
>Apache Flex PMC
>[hidden email]
>--
>View this message in context:
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-fle
>x-development.2333347.n4.nabble.com%2FFlexJS-Layout-of-NumericStepper-is-b
>roken-tp62108.html&data=02%7C01%7C%7Cccc8644d5a054e8cd1e508d4ac21a197%7Cfa
>7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636322707827257340&sdata=VESRAJBK
>DR%2FiSQd6M3xC7tB78jqMEgq%2Bh%2BPPMfj7f%2FM%3D&reserved=0
>Sent from the Apache Flex Development mailing list archive at Nabble.com.

Reply | Threaded
Open this post in threaded view
|

Re: [FlexJS] Layout of NumericStepper is broken

piotrz
Hi Peter,

It is Windows 10 and Chrome 59.0.3071.82
I tried also on Firefox: 53.0.3 (32 bits)

Piotr
Reply | Threaded
Open this post in threaded view
|

Re: [FlexJS] Layout of NumericStepper is broken

Alex Harui-2
Run the FlexJSStore example and go to the Products tab.  NumericStepper
looks fine to me there.

-Alex

On 6/5/17, 7:49 AM, "piotrz" <[hidden email]> wrote:

>Hi Peter,
>
>It is Windows 10 and Chrome 59.0.3071.82
>I tried also on Firefox: 53.0.3 (32 bits)
>
>Piotr
>
>
>
>-----
>Apache Flex PMC
>[hidden email]
>--
>View this message in context:
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-fle
>x-development.2333347.n4.nabble.com%2FFlexJS-Layout-of-NumericStepper-is-b
>roken-tp62108p62110.html&data=02%7C01%7C%7Cbda19d424c0b45a9d60508d4ac2432c
>4%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636322718850362569&sdata=nW
>1D5fHhhRvqVe40HWaEaJgnvRfofBb8Ejw8B1q2dh4%3D&reserved=0
>Sent from the Apache Flex Development mailing list archive at Nabble.com.

Reply | Threaded
Open this post in threaded view
|

Re: [FlexJS] Layout of NumericStepper is broken

piotrz
Reply | Threaded
Open this post in threaded view
|

Re: [FlexJS] Layout of NumericStepper is broken

Peter Ent-2
OK, thanks. I'm looking at this now (as soon as my sync of Alex's changes
completes).
‹peter

On 6/6/17, 3:17 AM, "piotrz" <[hidden email]> wrote:

>Peter,
>
>I just raised jira ->
>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.ap
>ache.org%2Fjira%2Fbrowse%2FFLEX-35322&data=02%7C01%7C%7Cafd0984b2a2d4a2643
>d308d4acae46fd%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63632331191193
>2511&sdata=6aA%2FoP%2BRTmEXaHh0aU2pRgufprYkfmGw7tmkipKsFMM%3D&reserved=0
>
>Piotr
>
>
>
>-----
>Apache Flex PMC
>[hidden email]
>--
>View this message in context:
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-fle
>x-development.2333347.n4.nabble.com%2FFlexJS-Layout-of-NumericStepper-is-b
>roken-tp62108p62149.html&data=02%7C01%7C%7Cafd0984b2a2d4a2643d308d4acae46f
>d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636323311911932511&sdata=io
>xNCT03PcPjwOIytCr2%2FUjst9mGuqx2b%2BCTLqBJ7Kw%3D&reserved=0
>Sent from the Apache Flex Development mailing list archive at Nabble.com.

Reply | Threaded
Open this post in threaded view
|

Re: [FlexJS] Layout of NumericStepper is broken

Peter Ent-2
In reply to this post by piotrz
I found the problem: the NumericStepper's sizeChange handler was not being
called when the NS appears in this simpler test case. It is being called
when it is displayed in the FlexJSStore, for example. The more complex app
with nested containers and layouts is setting the right conditions so the
size change handler runs.

If I remove the test and always call the size change handler, both this
simple test and the FlexJSStore work fine. But there are some minor
alignment issues which I can also correct.

I don't want to check in my changes without having Alex think about why
those changes were put in place since there may be consequences of
returning the NS to a more simpler form.

‹peter

On 6/6/17, 3:17 AM, "piotrz" <[hidden email]> wrote:

>Peter,
>
>I just raised jira ->
>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.ap
>ache.org%2Fjira%2Fbrowse%2FFLEX-35322&data=02%7C01%7C%7Cafd0984b2a2d4a2643
>d308d4acae46fd%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63632331191193
>2511&sdata=6aA%2FoP%2BRTmEXaHh0aU2pRgufprYkfmGw7tmkipKsFMM%3D&reserved=0
>
>Piotr
>
>
>
>-----
>Apache Flex PMC
>[hidden email]
>--
>View this message in context:
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-fle
>x-development.2333347.n4.nabble.com%2FFlexJS-Layout-of-NumericStepper-is-b
>roken-tp62108p62149.html&data=02%7C01%7C%7Cafd0984b2a2d4a2643d308d4acae46f
>d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636323311911932511&sdata=io
>xNCT03PcPjwOIytCr2%2FUjst9mGuqx2b%2BCTLqBJ7Kw%3D&reserved=0
>Sent from the Apache Flex Development mailing list archive at Nabble.com.