[FlexJS,TLF] Tlf branch and Maven build

classic Classic list List threaded Threaded
23 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[FlexJS,TLF] Tlf branch and Maven build

piotrz
Hi Harbs,

I noticed that TLF branch do not have proper Maven build on jenkins. I would like to create one for you. In order to do this I need to create branch named tlf in typedefs and falcon repo.

As I understand your branch was created from develop and release branch is merged there ?

Thanks,
Piotr
Apache Flex PMC
piotrzarzycki21@gmail.com
Reply | Threaded
Open this post in threaded view
|

Re: [FlexJS,TLF] Tlf branch and Maven build

Harbs
Yes.

But I’m not sure it currently makes sense to create a Maven branch.

I don’t think I’m merging it in any time soon and I’m perfectly happy building with ant. I’m not going to spend time fixing Maven builds if they break on the branch, so I’m not sure there’s any benefit in doing so.

That said; if you want to create the maven build, I will not stand in your way.

Harbs

> On Jun 18, 2017, at 1:27 PM, piotrz <[hidden email]> wrote:
>
> Hi Harbs,
>
> I noticed that TLF branch do not have proper Maven build on jenkins. I would
> like to create one for you. In order to do this I need to create branch
> named tlf in typedefs and falcon repo.
>
> As I understand your branch was created from develop and release branch is
> merged there ?
>
> Thanks,
> Piotr
>
>
>
> -----
> Apache Flex PMC
> [hidden email]
> --
> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-TLF-Tlf-branch-and-Maven-build-tp62452.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.

Reply | Threaded
Open this post in threaded view
|

Re: [FlexJS,TLF] Tlf branch and Maven build

piotrz
Thanks for the info! I will create it - I think you may have some benefit from that if you start play with Maven.

Piotr
Apache Flex PMC
piotrzarzycki21@gmail.com
Reply | Threaded
Open this post in threaded view
|

Re: [FlexJS,TLF] Tlf branch and Maven build

piotrz
In reply to this post by Harbs
Additionally we need to put such branches in the future to some folder feature/ etc. It is started to be messy on our git.

Piotr
Apache Flex PMC
piotrzarzycki21@gmail.com
Reply | Threaded
Open this post in threaded view
|

Re: [FlexJS,TLF] Tlf branch and Maven build

piotrz
In reply to this post by Harbs
Harbs,

Creating this means that I will have to update your tlf branch with 0.9.0-SNAPSHOT. ("develop") I hope it is ok for you.

Let me know.

Piotr
Apache Flex PMC
piotrzarzycki21@gmail.com
Reply | Threaded
Open this post in threaded view
|

Re: [FlexJS,TLF] Tlf branch and Maven build

Harbs
Does develop have all the changes in the release branch?

Make sure you don’t revert any changes there…

> On Jun 18, 2017, at 2:49 PM, piotrz <[hidden email]> wrote:
>
> Harbs,
>
> Creating this means that I will have to update your tlf branch with
> 0.9.0-SNAPSHOT. ("develop") I hope it is ok for you.
>
> Let me know.
>
> Piotr
>
>
>
> -----
> Apache Flex PMC
> [hidden email]
> --
> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-TLF-Tlf-branch-and-Maven-build-tp62452p62457.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.

Reply | Threaded
Open this post in threaded view
|

Re: [FlexJS,TLF] Tlf branch and Maven build

piotrz
I did following things:

Merge develop to tlf - conflicts only in poms - as expected.
Merge release branch to tlf - conflicts in poms. Changes are in UIBase related to Justin's findings != to !== etc.

Your branch was pretty fresh as I see.

I think I didn't revert anything doing that.

Piotr
Apache Flex PMC
piotrzarzycki21@gmail.com
Reply | Threaded
Open this post in threaded view
|

Re: [FlexJS,TLF] Tlf branch and Maven build

Harbs
Yes. it was merged not too long ago.

Sounds good.

> On Jun 18, 2017, at 3:04 PM, piotrz <[hidden email]> wrote:
>
> I did following things:
>
> Merge develop to tlf - conflicts only in poms - as expected.
> Merge release branch to tlf - conflicts in poms. Changes are in UIBase
> related to Justin's findings != to !== etc.
>
> Your branch was pretty fresh as I see.
>
> I think I didn't revert anything doing that.
>
> Piotr
>
>
>
> -----
> Apache Flex PMC
> [hidden email]
> --
> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-TLF-Tlf-branch-and-Maven-build-tp62452p62459.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.

Reply | Threaded
Open this post in threaded view
|

Re: [FlexJS,TLF] Tlf branch and Maven build

piotrz
Here you go your private tlf pipeline on Jenkins :) [1]. Compiler and typdefs are building ok, but FlexJS failed cause rat complains about some un-approved files license.

I did also ceate for tests pom for Text module [2] and build failed with lots of errors. If you do not experience any errors building by Ant that's not good. Maybe Maven is a bit more restrict about some things. You need to try on your own. Copy pom [2] to Text folder and run mvn clean install - There is possibility that some dependencies are missing, but not sure what Text module need in order to build. I add only Core and Binding.

[1] https://builds.apache.org/view/E-G/view/Flex/job/FlexJS%20Pipeline/job/tlf/
[2] https://paste.apache.org/8T2e

Piotr
Apache Flex PMC
piotrzarzycki21@gmail.com
Reply | Threaded
Open this post in threaded view
|

Re: [FlexJS,TLF] Tlf branch and Maven build

Harbs
> There is possibility that some dependencies are missing, but not sure what
> Text module need in order to build. I add only Core and Binding.

It needs Core, Basic and HTML.

> On Jun 18, 2017, at 4:28 PM, piotrz <[hidden email]> wrote:
>
> Here you go your private tlf pipeline on Jenkins :) [1]. Compiler and typdefs
> are building ok, but FlexJS failed cause rat complains about some
> un-approved files license.
>
> I did also ceate for tests pom for Text module [2] and build failed with
> lots of errors. If you do not experience any errors building by Ant that's
> not good. Maybe Maven is a bit more restrict about some things. You need to
> try on your own. Copy pom [2] to Text folder and run mvn clean install -
> There is possibility that some dependencies are missing, but not sure what
> Text module need in order to build. I add only Core and Binding.
>
> [1]
> https://builds.apache.org/view/E-G/view/Flex/job/FlexJS%20Pipeline/job/tlf/
> [2] https://paste.apache.org/8T2e
>
> Piotr
>
>
>
> -----
> Apache Flex PMC
> [hidden email]
> --
> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-TLF-Tlf-branch-and-Maven-build-tp62452p62461.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.

Reply | Threaded
Open this post in threaded view
|

Re: [FlexJS,TLF] Tlf branch and Maven build

piotrz
Harbs,

I just add to Text and TLF poms and make both modules part of general build, so now your work will be build also by Maven. :)

Add also license header to one of the file. Build is in progress [1]

[1] https://builds.apache.org/view/E-G/view/Flex/job/FlexJS%20Pipeline/job/tlf/

Piotr
Apache Flex PMC
piotrzarzycki21@gmail.com
Reply | Threaded
Open this post in threaded view
|

Re: [FlexJS,TLF] Tlf branch and Maven build

piotrz
In reply to this post by Harbs
Wow :) After 4 shots it is finally blue [1] :)  


[1] https://builds.apache.org/view/E-G/view/Flex/job/FlexJS%20Pipeline/job/tlf/4/

Piotr

Apache Flex PMC
piotrzarzycki21@gmail.com
Reply | Threaded
Open this post in threaded view
|

Re: [FlexJS,TLF] Tlf branch and Maven build

Harbs
Nice.

I’ll try not to break this… ;-)

> On Jun 18, 2017, at 10:33 PM, piotrz <[hidden email]> wrote:
>
> Wow :) After 4 shots it is finally blue [1] :)  
>
>
> [1]
> https://builds.apache.org/view/E-G/view/Flex/job/FlexJS%20Pipeline/job/tlf/4/
>
> Piotr
>
>
>
>
>
> -----
> Apache Flex PMC
> [hidden email]
> --
> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-TLF-Tlf-branch-and-Maven-build-tp62452p62468.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.

Reply | Threaded
Open this post in threaded view
|

Re: [FlexJS,TLF] Tlf branch and Maven build

piotrz
Hi Harbs,

I see that your TLF branch is failing on Maven build [1] with following stack:

Loading configuration: F:\jenkins\jenkins-slave\workspace\FlexJS_Pipeline_tlf-FPPLDH3IED5DAGFHRJL7RRGRIFBYTXXVJMECBOAQYUNMJQLGIAAQ\framework\frameworks\projects\Basic\target\compile-swf-config.xml

Error: 'spark.core.SpriteVisualElement' could not be found in scope.


'spark.core.SpriteVisualElement' could not be found in scope.

[1] https://builds.apache.org/view/E-G/view/Flex/job/FlexJS%20Pipeline/job/tlf/8/

Piotr
Apache Flex PMC
piotrzarzycki21@gmail.com
Reply | Threaded
Open this post in threaded view
|

Re: [FlexJS,TLF] Tlf branch and Maven build

Harbs
There is no reference to SpriteVisualElement anywhere.

Alex added support to FXG which uses flash.display.Sprite.

Maybe there’s something configured wrong with Maven causing it to get confused and  think there’s a dependency on SpriteVisualElement?

Is the latest falcon being built? (There were falcon changes that are required.)

> On Jun 27, 2017, at 9:46 PM, piotrz <[hidden email]> wrote:
>
> Hi Harbs,
>
> I see that your TLF branch is failing on Maven build [1] with following
> stack:
>
> Loading configuration:
> F:\jenkins\jenkins-slave\workspace\FlexJS_Pipeline_tlf-FPPLDH3IED5DAGFHRJL7RRGRIFBYTXXVJMECBOAQYUNMJQLGIAAQ\framework\frameworks\projects\Basic\target\compile-swf-config.xml
>
> Error: 'spark.core.SpriteVisualElement' could not be found in scope.
>
>
> 'spark.core.SpriteVisualElement' could not be found in scope.
>
> [1]
> https://builds.apache.org/view/E-G/view/Flex/job/FlexJS%20Pipeline/job/tlf/8/
>
> Piotr
>
>
>
> -----
> Apache Flex PMC
> [hidden email]
> --
> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-TLF-Tlf-branch-and-Maven-build-tp62452p62643.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.

Reply | Threaded
Open this post in threaded view
|

Re: [FlexJS,TLF] Tlf branch and Maven build

piotrz
I think it is related to his changes. I just tried build Basic locally and it's failed with same stacktrace. I got update of falcon beforehand.

Maybe Alex will have some thoughts on that.

Thanks,
Piotr
Apache Flex PMC
piotrzarzycki21@gmail.com
Reply | Threaded
Open this post in threaded view
|

Re: [FlexJS,TLF] Tlf branch and Maven build

Alex Harui-2
I had to update some poms.

-Alex

On 6/27/17, 12:15 PM, "piotrz" <[hidden email]> wrote:

>I think it is related to his changes. I just tried build Basic locally and
>it's failed with same stacktrace. I got update of falcon beforehand.
>
>Maybe Alex will have some thoughts on that.
>
>Thanks,
>Piotr
>
>
>
>-----
>Apache Flex PMC
>[hidden email]
>--
>View this message in context:
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-fle
>x-development.2333347.n4.nabble.com%2FFlexJS-TLF-Tlf-branch-and-Maven-buil
>d-tp62452p62645.html&data=02%7C01%7C%7C18001132a7cf490a9d0308d4bd94f8de%7C
>fa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636341894903818427&sdata=SIN%2F
>zvPD4WV65%2FRFAuixK%2B2vEJjDSFtjRUwwfgDgUnE%3D&reserved=0
>Sent from the Apache Flex Development mailing list archive at Nabble.com.

Reply | Threaded
Open this post in threaded view
|

Re: [FlexJS,TLF] Tlf branch and Maven build

Peter Ent-2
I just added something to TLF branch, in the DragDrop project. There is
now a dependency on Collections; does a pom file need to be changed to
reflect that or is the compile-swf-config file enough?

‹peter

On 6/27/17, 4:41 PM, "Alex Harui" <[hidden email]> wrote:

>I had to update some poms.
>
>-Alex
>
>On 6/27/17, 12:15 PM, "piotrz" <[hidden email]> wrote:
>
>>I think it is related to his changes. I just tried build Basic locally
>>and
>>it's failed with same stacktrace. I got update of falcon beforehand.
>>
>>Maybe Alex will have some thoughts on that.
>>
>>Thanks,
>>Piotr
>>
>>
>>
>>-----
>>Apache Flex PMC
>>[hidden email]
>>--
>>View this message in context:
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-fl
>>e
>>x-development.2333347.n4.nabble.com%2FFlexJS-TLF-Tlf-branch-and-Maven-bui
>>l
>>d-tp62452p62645.html&data=02%7C01%7C%7C18001132a7cf490a9d0308d4bd94f8de%7
>>C
>>fa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636341894903818427&sdata=SIN%2
>>F
>>zvPD4WV65%2FRFAuixK%2B2vEJjDSFtjRUwwfgDgUnE%3D&reserved=0
>>Sent from the Apache Flex Development mailing list archive at Nabble.com.
>

Reply | Threaded
Open this post in threaded view
|

Re: [FlexJS,TLF] Tlf branch and Maven build

Alex Harui-2
Every time we change compile-swf-config or compile-js-config we have to
remember that we might have to change the pom.xml.  I keep forgetting to
check the pom.  

However, DragDrop worked for me.  We'll see what the CI server says.

-Alex

On 6/27/17, 1:47 PM, "Peter Ent" <[hidden email]> wrote:

>I just added something to TLF branch, in the DragDrop project. There is
>now a dependency on Collections; does a pom file need to be changed to
>reflect that or is the compile-swf-config file enough?
>
>‹peter
>
>On 6/27/17, 4:41 PM, "Alex Harui" <[hidden email]> wrote:
>
>>I had to update some poms.
>>
>>-Alex
>>
>>On 6/27/17, 12:15 PM, "piotrz" <[hidden email]> wrote:
>>
>>>I think it is related to his changes. I just tried build Basic locally
>>>and
>>>it's failed with same stacktrace. I got update of falcon beforehand.
>>>
>>>Maybe Alex will have some thoughts on that.
>>>
>>>Thanks,
>>>Piotr
>>>
>>>
>>>
>>>-----
>>>Apache Flex PMC
>>>[hidden email]
>>>--
>>>View this message in context:
>>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-f
>>>l
>>>e
>>>x-development.2333347.n4.nabble.com%2FFlexJS-TLF-Tlf-branch-and-Maven-bu
>>>i
>>>l
>>>d-tp62452p62645.html&data=02%7C01%7C%7C18001132a7cf490a9d0308d4bd94f8de%
>>>7
>>>C
>>>fa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636341894903818427&sdata=SIN%
>>>2
>>>F
>>>zvPD4WV65%2FRFAuixK%2B2vEJjDSFtjRUwwfgDgUnE%3D&reserved=0
>>>Sent from the Apache Flex Development mailing list archive at
>>>Nabble.com.
>>
>

Reply | Threaded
Open this post in threaded view
|

Re: [FlexJS,TLF] Tlf branch and Maven build

yishayw
I'm getting this problem with ant clean all as well. Before running ant clean all I tried running "ant wipe" in flex-typedefs and "ant wipe-all" in
flex-falcon, and "ant super-clean" in flex-asjs.

     [java] C:\dev\flexjs\flex-asjs\frameworks\projects\Basic\src\main\config\compile-swf-config.xml(47): col: 0 unknown configuration variable 'compiler.fxg-base-class'.
     [java] C:\dev\flexjs\flex-asjs\frameworks\projects\Basic\src\main\config\compile-swf-config.xml (line: 47)
     [java]
     [java]         <fxg-base-class>flash.display.Sprite</fxg-base-class>
     [java]
     [java]
     [java] Java Result: 4
12