[FlexJS] feature branch

classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[FlexJS] feature branch

Peter Ent
Hi,

I've pushed feature/chart-work that contains updates to the Chart package, but also other structural changes to HTML to support it.

If you have time, check it out and see if your work builds and runs with it. MDL might need a little refactoring; I have it compiling but I do not know yet if the examples work.

This is still a work-in-progress.

—peter
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [FlexJS] feature branch

piotrz
Hi Peter,

I just checked your branch and MDL look fine. In order to build it I had to merge current develop to your branch I hope that you don't mind if I pushit it. Changes which come from develop wasn't also breakage. Mainly maven pom changes and ListExample.

Piotr
Apache Flex PMC
piotrzarzycki21@gmail.com
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [FlexJS] feature branch

Christofer Dutz
And I just added that branch to compiler and typedefs and now you have your free Jenkins Build (

https://builds.apache.org/view/E-G/view/Flex/job/FlexJS%20Pipeline/


Chris

Am 30.03.17, 06:59 schrieb "piotrz" <[hidden email]>:

    Hi Peter,
   
    I just checked your branch and MDL look fine. In order to build it I had to
    merge current develop to your branch I hope that you don't mind if I pushit
    it. Changes which come from develop wasn't also breakage. Mainly maven pom
    changes and ListExample.
   
    Piotr
   
   
   
    -----
    Apache Flex PMC
    [hidden email]
    --
    View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-feature-branch-tp60916p60918.html
    Sent from the Apache Flex Development mailing list archive at Nabble.com.
   

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [FlexJS] feature branch

Peter Ent
Thanks!
‹peter

On 3/30/17, 3:34 AM, "Christofer Dutz" <[hidden email]> wrote:

>And I just added that branch to compiler and typedefs and now you have
>your free Jenkins Build (
>
>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbuilds.ap
>ache.org%2Fview%2FE-G%2Fview%2FFlex%2Fjob%2FFlexJS%2520Pipeline%2F&data=02
>%7C01%7C%7Cbd0687cb04dd4f9b7ca608d4773f3d7a%7Cfa7b1b5a7b34438794aed2c178de
>cee1%7C0%7C0%7C636264560888241509&sdata=uCwt48pMvDKa5kDcHaPgaVIhRhEMXHaKXC
>MnvUNTUvU%3D&reserved=0
>
>
>Chris
>
>Am 30.03.17, 06:59 schrieb "piotrz" <[hidden email]>:
>
>    Hi Peter,
>    
>    I just checked your branch and MDL look fine. In order to build it I
>had to
>    merge current develop to your branch I hope that you don't mind if I
>pushit
>    it. Changes which come from develop wasn't also breakage. Mainly
>maven pom
>    changes and ListExample.
>    
>    Piotr
>    
>    
>    
>    -----
>    Apache Flex PMC
>    [hidden email]
>    --
>    View this message in context:
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-fle
>x-development.2333347.n4.nabble.com%2FFlexJS-feature-branch-tp60916p60918.
>html&data=02%7C01%7C%7Cbd0687cb04dd4f9b7ca608d4773f3d7a%7Cfa7b1b5a7b344387
>94aed2c178decee1%7C0%7C0%7C636264560888241509&sdata=fn8aRP19hQ6svTCkwRiT7w
>MxVcieQVwPuCNWEEeOJKY%3D&reserved=0
>    Sent from the Apache Flex Development mailing list archive at
>Nabble.com.
>    
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [FlexJS] feature branch

Peter Ent
In reply to this post by piotrz
Yes, please push the changes when you can. Thank you!
‹peter

On 3/30/17, 12:59 AM, "piotrz" <[hidden email]> wrote:

>Hi Peter,
>
>I just checked your branch and MDL look fine. In order to build it I had
>to
>merge current develop to your branch I hope that you don't mind if I
>pushit
>it. Changes which come from develop wasn't also breakage. Mainly maven pom
>changes and ListExample.
>
>Piotr
>
>
>
>-----
>Apache Flex PMC
>[hidden email]
>--
>View this message in context:
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-fle
>x-development.2333347.n4.nabble.com%2FFlexJS-feature-branch-tp60916p60918.
>html&data=02%7C01%7C%7C8361970bedab42d55bfd08d4772ac759%7Cfa7b1b5a7b344387
>94aed2c178decee1%7C0%7C0%7C636264472995482886&sdata=VD6J1EA%2BSjGKI4VUXuHo
>zLENiwvNRmgEyaUtp4LOjWs%3D&reserved=0
>Sent from the Apache Flex Development mailing list archive at Nabble.com.

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [FlexJS] feature branch

Peter Ent
In reply to this post by piotrz
Hi,

I took a look at your changes to ListExample. I see I forgot to put in a
ReadMe or some comments to show why the example is written the way it is.

The example is supposed to show a deconstruction of a list, by starting
with UIBase and adding in the things that make a list a "List". The point
is to show that FlexJS "advanced" components are really compositions that
can be made in MXML by starting with UIBase and adding in the right beads
to make a component and implementing the right interfaces.

But since I never put in the note, you had no way to know that!

What I think we can do is add in an alternative View MXML file that shows
the deconstruction along with a decent explanation.

I apologize for not making the example's purpose clear. I think your
changes will do nicely to show a way to make a list using DataContainer.

‹peter

On 3/30/17, 12:59 AM, "piotrz" <[hidden email]> wrote:

>Hi Peter,
>
>I just checked your branch and MDL look fine. In order to build it I had
>to
>merge current develop to your branch I hope that you don't mind if I
>pushit
>it. Changes which come from develop wasn't also breakage. Mainly maven pom
>changes and ListExample.
>
>Piotr
>
>
>
>-----
>Apache Flex PMC
>[hidden email]
>--
>View this message in context:
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-fle
>x-development.2333347.n4.nabble.com%2FFlexJS-feature-branch-tp60916p60918.
>html&data=02%7C01%7C%7C8361970bedab42d55bfd08d4772ac759%7Cfa7b1b5a7b344387
>94aed2c178decee1%7C0%7C0%7C636264472995482886&sdata=VD6J1EA%2BSjGKI4VUXuHo
>zLENiwvNRmgEyaUtp4LOjWs%3D&reserved=0
>Sent from the Apache Flex Development mailing list archive at Nabble.com.

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [FlexJS] feature branch

Peter Ent
In reply to this post by Peter Ent
I have to revert the change to UIBase that sets position:absolute when
either .x or .y properties are set on the JS-side. Using absolute position
messes with some layouts.

All of the layout code that requires position:absolute sets it when
needed. BasicLayout, for example, sets position:absolute on each child and
then checks the strand. If it doesn't have position set to either absolute
or relative, it sets the strand's element's position to relative to ensure
the absolute positioning of the children apply relative to the strand.

If your component work needs to set .x and .y you have a couple of
alternatives:

1: Write your component using Group or Container as its base class. Then
add in the BasicLayout bead.
2: If your component is UIBase based, then use COMPILE::JS block to set
element.style.position = "absolute" whenever you set .x or .y.

We can also make a UIComponentBase class that extends GroupBase and puts
in BasicLayout. Then you just need to trigger the layout once your view
has been created and whenever it changes side.

—peter

On 3/30/17, 8:23 AM, "Peter Ent" <[hidden email]> wrote:

>Yes, please push the changes when you can. Thank you!
>‹peter
>
>On 3/30/17, 12:59 AM, "piotrz" <[hidden email]> wrote:
>
>>Hi Peter,
>>
>>I just checked your branch and MDL look fine. In order to build it I had
>>to
>>merge current develop to your branch I hope that you don't mind if I
>>pushit
>>it. Changes which come from develop wasn't also breakage. Mainly maven
>>pom
>>changes and ListExample.
>>
>>Piotr
>>
>>
>>
>>-----
>>Apache Flex PMC
>>[hidden email]
>>--
>>View this message in context:
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-fl
>>e
>>x-development.2333347.n4.nabble.com%2FFlexJS-feature-branch-tp60916p60918
>>.
>>html&data=02%7C01%7C%7C8361970bedab42d55bfd08d4772ac759%7Cfa7b1b5a7b34438
>>7
>>94aed2c178decee1%7C0%7C0%7C636264472995482886&sdata=VD6J1EA%2BSjGKI4VUXuH
>>o
>>zLENiwvNRmgEyaUtp4LOjWs%3D&reserved=0
>>Sent from the Apache Flex Development mailing list archive at Nabble.com.
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [FlexJS] feature branch

Peter Ent
In reply to this post by Peter Ent
Hi,

I've pushed a new set of changes to feature/chart-work branch. There has
been a little restructuring of the container classes to remove code
redundancies and improve the perform a little.

If you can, please try your stuff again. You shouldn't see any differences
(fingers crossed). I know some components aren't behaving quite right yet.
I have this list so far:

Checkbox and RadioBox are not laying out properly.
Tree on the SWF side isn't responding to clicks.
DateChooser looks good, but DateField pop-up on JS is in the wrong place
(due to missing position style and miscalculation of its location) now
that nesting of elements has disappeared.

The charts look back to normal except for the "optimized" SVG version; I
think that's a position style issue, too.

Thanks,
Peter

PS: This feature branch thing really was a good idea.


On 3/29/17, 5:28 PM, "Peter Ent" <[hidden email]> wrote:

>Hi,
>
>I've pushed feature/chart-work that contains updates to the Chart
>package, but also other structural changes to HTML to support it.
>
>If you have time, check it out and see if your work builds and runs with
>it. MDL might need a little refactoring; I have it compiling but I do not
>know yet if the examples work.
>
>This is still a work-in-progress.
>
>‹peter

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [FlexJS] feature branch

piotrz
Hi Peter,

I just tried branch and it's not building for me [1]. That's strange error - do you know what can it be ?


[1] https://paste.apache.org/MoHw

Piotr
Apache Flex PMC
piotrzarzycki21@gmail.com
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [FlexJS] feature branch

piotrz
In reply to this post by Peter Ent
Peter,

Develop has exactly same issue and Jenkins reported it also [1]

[1] https://builds.apache.org/view/E-G/view/Flex/job/FlexJS%20Pipeline/job/feature%252Fchart-work/2/console

Piotr
Apache Flex PMC
piotrzarzycki21@gmail.com
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [FlexJS] feature branch

Peter Ent
It looks like there is more work to do with Falcon, if I'm reading this
right.
‹peter

On 3/31/17, 1:32 AM, "piotrz" <[hidden email]> wrote:

>Peter,
>
>Develop has exactly same issue and Jenkins reported it also [1]
>
>[1]
>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbuilds.ap
>ache.org%2Fview%2FE-G%2Fview%2FFlex%2Fjob%2FFlexJS%2520Pipeline%2Fjob%2Ffe
>ature%25252Fchart-work%2F2%2Fconsole&data=02%7C01%7C%7C02bb704a9a3345b445f
>c08d477f87715%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636265356413579
>952&sdata=oN%2FbbgJon0kEjmHDRzqrK4Zn0VhV1d5USzwdqcxAr5o%3D&reserved=0
>
>Piotr
>
>
>
>-----
>Apache Flex PMC
>[hidden email]
>--
>View this message in context:
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-fle
>x-development.2333347.n4.nabble.com%2FFlexJS-feature-branch-tp60916p60936.
>html&data=02%7C01%7C%7C02bb704a9a3345b445fc08d477f87715%7Cfa7b1b5a7b344387
>94aed2c178decee1%7C0%7C0%7C636265356413589960&sdata=auUHCX1Lx3vKZ7eNWM76%2
>BrWVHvGHbVbolknh2PvpScU%3D&reserved=0
>Sent from the Apache Flex Development mailing list archive at Nabble.com.

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [FlexJS] feature branch

piotrz
Peter,

I think Alex in his last commit fixed it - I will merge it to this branch.

I just tried your last changes and it look like something is broken in MDL example. I will take a look over the weekend if you not beat me early.

Piotr
Apache Flex PMC
piotrzarzycki21@gmail.com
Loading...