[GitHub] [flex-blazeds] ShangwenWang opened a new pull request #6: Change method name from "rememberObject" to "putObject"

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [flex-blazeds] ShangwenWang opened a new pull request #6: Change method name from "rememberObject" to "putObject"

GitBox

ShangwenWang opened a new pull request #6:
URL: https://github.com/apache/flex-blazeds/pull/6


   There is an explicit verb in the implementation of this method, *put*.
   Hence, changing the method name to "putObject" can better describe the intention of this method.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [flex-blazeds] justinmclean commented on pull request #6: Change method name from "rememberObject" to "putObject"

GitBox

justinmclean commented on pull request #6:
URL: https://github.com/apache/flex-blazeds/pull/6#issuecomment-772289230


   I think the existing name describes it better, but that may only be because I'm a native English speaker.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [flex-blazeds] ShangwenWang commented on pull request #6: Change method name from "rememberObject" to "putObject"

GitBox
In reply to this post by GitBox

ShangwenWang commented on pull request #6:
URL: https://github.com/apache/flex-blazeds/pull/6#issuecomment-772491317


   Thanks for your reply


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]