[GitHub] flex-blazeds pull request: Fix streaming on tomcat-7.0.27 + versio...

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] flex-blazeds pull request: Fix streaming on tomcat-7.0.27 + versio...

asfgit
GitHub user charithdesilva opened a pull request:

    https://github.com/apache/flex-blazeds/pull/1

    Fix streaming on tomcat-7.0.27 + version.

    https://bz.apache.org/bugzilla/show_bug.cgi?id=53169
   
    Tomcat close off the connection on connection-close header + chunk-encoding scenarios. Chunking happening only when there is no Connection: close header found.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/charithdesilva/flex-blazeds master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flex-blazeds/pull/1.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1
   
----
commit 0e3be5953d9f6fe8fd7f093c086e0fcac131c744
Author: Charith De Silva <[hidden email]>
Date:   2015-07-02T04:28:59Z

    Fix streaming on tomcat-7.0.27 + version.
   
    https://bz.apache.org/bugzilla/show_bug.cgi?id=53169
   
    Tomcat close off the connection on connection-close header + chunk-encoding scenarios. Chunking happening only when there is no Connection: close header found.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] flex-blazeds pull request: Fix streaming on tomcat-7.0.27 + versio...

asfgit
Github user chrisdutz commented on the pull request:

    https://github.com/apache/flex-blazeds/pull/1#issuecomment-118022223
 
    I would like to review this before applying ... as currently I don't quite understand it yet and I don't want to apply changes I don't understand. Have to do a little reading first ;-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] flex-blazeds pull request: Fix streaming on tomcat-7.0.27 + versio...

asfgit
In reply to this post by asfgit
Github user charithdesilva commented on the pull request:

    https://github.com/apache/flex-blazeds/pull/1#issuecomment-118242500
 
    Thanks Chris. If you are interested I have blogged about this also with a hack I did to get around this.
    https://charithdesilva.wordpress.com/2015/07/02/hacking-blazeds-to-get-streaming-working-on-tomcat/
   



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] flex-blazeds pull request: Fix streaming on tomcat-7.0.27 + versio...

asfgit
In reply to this post by asfgit
Github user chrisdutz commented on the pull request:

    https://github.com/apache/flex-blazeds/pull/1#issuecomment-118256530
 
    Great ... this is exaclty what I needed :-) .. I'll dig into this and apply your patch as soon as possible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] flex-blazeds pull request: Fix streaming on tomcat-7.0.27 + versio...

asfgit
In reply to this post by asfgit
Github user chrisdutz commented on the pull request:

    https://github.com/apache/flex-blazeds/pull/1#issuecomment-125882953
 
    Ok ... so I added a Jira Issue with the details. I also locally performed the changes you proposed. They will be part of the 4.8.0 which we are planing on releasing soon. Could you please close this pull request? Unfortunately we can't "accept" the changes using GitHub but have to manually apply the changes. So this is currently (as far as I know) the only way to do this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] flex-blazeds pull request: Fix streaming on tomcat-7.0.27 + versio...

asfgit
In reply to this post by asfgit
Github user Harbs commented on the pull request:

    https://github.com/apache/flex-blazeds/pull/1#issuecomment-126356638
 
    Chris, There's two ways you can close this:
   
    You can merge this pull request into a Git repository by running:
   
       $ git pull https://github.com/charithdesilva/flex-blazeds master
   
    Alternatively you can review and apply these changes as the patch at:
   
       https://github.com/apache/flex-blazeds/pull/1.patch
   
    To close this pull request, make a commit to your master/trunk branch
    with (at least) the following in the commit message:
   
       This closes #1



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] flex-blazeds pull request: Fix streaming on tomcat-7.0.27 + versio...

asfgit
In reply to this post by asfgit
Github user charithdesilva commented on the pull request:

    https://github.com/apache/flex-blazeds/pull/1#issuecomment-127129102
 
    Hi Chris
   
    Let me know if I need to close this or you can accept it the way suggested by Harbs.
   
    cheers
    Charith


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] flex-blazeds pull request: Fix streaming on tomcat-7.0.27 + versio...

asfgit
In reply to this post by asfgit
Github user cxjepa commented on the pull request:

    https://github.com/apache/flex-blazeds/pull/1#issuecomment-164632502
 
    Hi there,
    I can't understand why there are two distinct source codes of blazeds, both under the apache logo. The distribution I can download from apache web site is labeled 4.7 and use maven, this one is 4.7.2 and use ant, please help me on clarifying
    Greetings
    Simone


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] flex-blazeds pull request: Fix streaming on tomcat-7.0.27 + versio...

asfgit
In reply to this post by asfgit
Github user justinmclean commented on the pull request:

    https://github.com/apache/flex-blazeds/pull/1#issuecomment-164639248
 
    Bot 4.7 and 4.7.2 use maven to build the ant stuff is old. It looks like 4.7.2 hasn't been merged back into the master branch so you may of been looking at that. Check out the develop branch to see the most up to date instructions on how to build or ask on the dev list.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] flex-blazeds pull request: Fix streaming on tomcat-7.0.27 + versio...

asfgit
In reply to this post by asfgit
Github user chrisdutz commented on the pull request:

    https://github.com/apache/flex-blazeds/pull/1#issuecomment-164689928
 
    I really really have to delete the Ant stuff ... I didn't want to do it due to a lot of Ant-Men on the project, but it does seem to cause more problems than it solves. Geee ... you are correct ... I should update the master branch to the latest released version. Currently that's the branch 4.7.x (I think) ... 4.8.0 is the branch that's already cleaned up ... but I didn't make that official, as I didn't want to Upset the Ant enthusiasts.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] flex-blazeds pull request #1: Fix streaming on tomcat-7.0.27 + version.

asfgit
In reply to this post by asfgit
Github user asfgit closed the pull request at:

    https://github.com/apache/flex-blazeds/pull/1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...