[GitHub] flex-sdk pull request #46: Fix issue with Spark Grid scrolling/alignment whe...

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] flex-sdk pull request #46: Fix issue with Spark Grid scrolling/alignment whe...

piotrzarzycki21
GitHub user pzahra opened a pull request:

    https://github.com/apache/flex-sdk/pull/46

    Fix issue with Spark Grid scrolling/alignment when using locked columns/rows

    Contrary to StackOverflow belief, lockedColumnCount and lockedRowCount are usable in the Spark DataGrid, but the item renderer "selected" state is misaligned. Scrollbars are also misaligned when changing dataProvider. This fixes it.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pzahra/flex-sdk develop

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flex-sdk/pull/46.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #46
   
----
commit 47514f12536068973d6e4772171fd8e5aeea9b99
Author: Patrick Zahra <[hidden email]>
Date:   2017-10-30T20:33:31Z

    Fix issue with Spark Grid scrolling/alignment when using locked columns/rows

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] flex-sdk issue #46: Fix issue with Spark Grid scrolling/alignment when using...

piotrzarzycki21
Github user Harbs commented on the issue:

    https://github.com/apache/flex-sdk/pull/46
 
    Thanks for this. Do you have a small test case that demonstrates the improved behavior?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] flex-sdk issue #46: Fix issue with Spark Grid scrolling/alignment when using...

piotrzarzycki21
In reply to this post by piotrzarzycki21
Github user pzahra commented on the issue:

    https://github.com/apache/flex-sdk/pull/46
 
    Sure, I deleted that particular sandbox a while ago but I can describe it. Start with the old s:DataGrid, give it a dataset large enough to give it a nice long pair of scrollbars. Now set a couple of rows and columns to be locked (one column and three rows, I used). You'll need to provide a custom cell renderer like we had that sets its own background using the "selected" state instead of letting the control background show through (we were using this because some cells needed to be different colours and still indicate when they were selected). Run that and select some random cells. Notice that inside the main scrollable area the highlight is offset by the number of rows that are locked (not columns). If you have a second dataset that is smaller, switching to that while the data is scrolled all the way will also misalign the panes.


---