Re: [1/2] git commit: [flex-asjs] [refs/heads/develop] - Added method for garbage-collecting QNames

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [1/2] git commit: [flex-asjs] [refs/heads/develop] - Added method for garbage-collecting QNames

piotrz
Hi Harbs,

Could you add some additional info to all public methods such as version
when they were introduced ? Do you think that it could be helpful ?

Thanks,
Piotr


2017-09-19 10:35 GMT+02:00 <[hidden email]>:

> Repository: flex-asjs
> Updated Branches:
>   refs/heads/develop b217e2760 -> ccde57d11
>
>
> Added method for garbage-collecting QNames
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/6d63604c
> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/6d63604c
> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/6d63604c
>
> Branch: refs/heads/develop
> Commit: 6d63604cee888fe0c37f116ec8a781307bfe60e4
> Parents: 94754e0
> Author: Harbs <[hidden email]>
> Authored: Tue Sep 19 10:43:33 2017 +0300
> Committer: Harbs <[hidden email]>
> Committed: Tue Sep 19 10:43:33 2017 +0300
>
> ----------------------------------------------------------------------
>  frameworks/projects/XML/src/main/flex/XML.as | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/
> 6d63604c/frameworks/projects/XML/src/main/flex/XML.as
> ----------------------------------------------------------------------
> diff --git a/frameworks/projects/XML/src/main/flex/XML.as
> b/frameworks/projects/XML/src/main/flex/XML.as
> index ccaa67f..229d5f6 100644
> --- a/frameworks/projects/XML/src/main/flex/XML.as
> +++ b/frameworks/projects/XML/src/main/flex/XML.as
> @@ -56,6 +56,16 @@ package
>                         }
>                         return qname;
>                 }
> +
> +               /**
> +                * Method to free up references to shared QName objects.
> +                * Probably only worth doing if most or all XML instances
> can be garbage-collected.
> +                */
> +               static public function clearQNameCache():void
> +               {
> +                       _nameMap = {};
> +               }
> +
>                 static private var defaultNamespace:Namespace;
>
>                 static public function setDefaultNamespace(ns:*):void
>
>


--

Piotr Zarzycki

mobile: +48 880 859 557
skype: zarzycki10

LinkedIn: http://www.linkedin.com/piotrzarzycki
<https://pl.linkedin.com/in/piotr-zarzycki-92a53552>
Reply | Threaded
Open this post in threaded view
|

Re: [1/2] git commit: [flex-asjs] [refs/heads/develop] - Added method for garbage-collecting QNames

Harbs
Maybe. We’d have to have documentation on JS-specific APIs for that to be useful.

Otherwise, the APIs should be compatible with AS XNL and XMLList.

Harbs

> On Sep 19, 2017, at 11:43 AM, Piotr Zarzycki <[hidden email]> wrote:
>
> Hi Harbs,
>
> Could you add some additional info to all public methods such as version
> when they were introduced ? Do you think that it could be helpful ?
>
> Thanks,
> Piotr
>
>
> 2017-09-19 10:35 GMT+02:00 <[hidden email]>:
>
>> Repository: flex-asjs
>> Updated Branches:
>>  refs/heads/develop b217e2760 -> ccde57d11
>>
>>
>> Added method for garbage-collecting QNames
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/6d63604c
>> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/6d63604c
>> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/6d63604c
>>
>> Branch: refs/heads/develop
>> Commit: 6d63604cee888fe0c37f116ec8a781307bfe60e4
>> Parents: 94754e0
>> Author: Harbs <[hidden email]>
>> Authored: Tue Sep 19 10:43:33 2017 +0300
>> Committer: Harbs <[hidden email]>
>> Committed: Tue Sep 19 10:43:33 2017 +0300
>>
>> ----------------------------------------------------------------------
>> frameworks/projects/XML/src/main/flex/XML.as | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>> ----------------------------------------------------------------------
>>
>>
>> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/
>> 6d63604c/frameworks/projects/XML/src/main/flex/XML.as
>> ----------------------------------------------------------------------
>> diff --git a/frameworks/projects/XML/src/main/flex/XML.as
>> b/frameworks/projects/XML/src/main/flex/XML.as
>> index ccaa67f..229d5f6 100644
>> --- a/frameworks/projects/XML/src/main/flex/XML.as
>> +++ b/frameworks/projects/XML/src/main/flex/XML.as
>> @@ -56,6 +56,16 @@ package
>>                        }
>>                        return qname;
>>                }
>> +
>> +               /**
>> +                * Method to free up references to shared QName objects.
>> +                * Probably only worth doing if most or all XML instances
>> can be garbage-collected.
>> +                */
>> +               static public function clearQNameCache():void
>> +               {
>> +                       _nameMap = {};
>> +               }
>> +
>>                static private var defaultNamespace:Namespace;
>>
>>                static public function setDefaultNamespace(ns:*):void
>>
>>
>
>
> --
>
> Piotr Zarzycki
>
> mobile: +48 880 859 557
> skype: zarzycki10
>
> LinkedIn: http://www.linkedin.com/piotrzarzycki
> <https://pl.linkedin.com/in/piotr-zarzycki-92a53552>