Re: [1/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35337 place tool tip anchor point in the centre rather than the bottom right

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [1/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35337 place tool tip anchor point in the centre rather than the bottom right

Harbs
Why are you assuming that this behavior is wrong?

Don’t you think a functional change should require discussion?

Thanks,
Harbs

> On Jul 11, 2017, at 8:40 AM, [hidden email] wrote:
>
> Repository: flex-asjs
> Updated Branches:
>  refs/heads/develop e93c11d7c -> 1d73de00b
>
>
> FLEX-35337 place tool tip anchor point in the centre rather than the bottom right
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/38918204
> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/38918204
> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/38918204
>
> Branch: refs/heads/develop
> Commit: 3891820488387121767c92e1cf9c132f6e858496
> Parents: 54d00a0
> Author: Justin Mclean <[hidden email]>
> Authored: Tue Jul 11 14:43:29 2017 +1000
> Committer: Justin Mclean <[hidden email]>
> Committed: Tue Jul 11 14:43:29 2017 +1000
>
> ----------------------------------------------------------------------
> .../src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as  | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/38918204/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as
> ----------------------------------------------------------------------
> diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as
> index 64d04bf..03ce21e 100644
> --- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as
> +++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as
> @@ -122,7 +122,7 @@ package org.apache.flex.html.accessories
> protected function determinePosition(event:MouseEvent, base:Object):Point
> {
> var comp:IUIBase = _strand as IUIBase;
> - var pt:Point = new Point(comp.width, comp.height);
> + var pt:Point = new Point(comp.width/2, comp.height/2);
> pt = PointUtils.localToGlobal(pt, comp);
> return pt;
> }
>

Reply | Threaded
Open this post in threaded view
|

Re: [1/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35337 place tool tip anchor point in the centre rather than the bottom right

Justin Mclean
Administrator
Hi,

> Why are you assuming that this behavior is wrong?

Because if you have two components side by side and mouse over the first one the tool tip appears below the second one. If you have something on the right of the screen and roll over it you can’t see any tooltip. If you have something at the bottom of the screen and roll over it you can’t see any tooltip.

> Don’t you think a functional change should require discussion?

If you think it does please re open the JIRA and let's discuss.

One possibly would be to have two beads <ToolTipBottmLeftBead> and <ToolTipCentreBead> if it’s not clear what the default placement should be.

Thanks,
Justin
Reply | Threaded
Open this post in threaded view
|

Re: [1/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35337 place tool tip anchor point in the centre rather than the bottom right

Alex Harui-2
Yes, I think we need more variants.  Maybe the default tooltip bead should
be slightly fatter and have x/y offsets or some other way to dictate the
relative position.  There is no one right answer.  But changing code that
is being used in the examples is not a good practice.

Framework developers must learn to think about more than just the one
scenario they are working with.

Thanks,
-Alex

On 7/11/17, 4:08 PM, "Justin Mclean" <[hidden email]> wrote:

>Hi,
>
>> Why are you assuming that this behavior is wrong?
>
>Because if you have two components side by side and mouse over the first
>one the tool tip appears below the second one. If you have something on
>the right of the screen and roll over it you can’t see any tooltip. If
>you have something at the bottom of the screen and roll over it you can’t
>see any tooltip.
>
>> Don’t you think a functional change should require discussion?
>
>If you think it does please re open the JIRA and let's discuss.
>
>One possibly would be to have two beads <ToolTipBottmLeftBead> and
><ToolTipCentreBead> if it’s not clear what the default placement should
>be.
>
>Thanks,
>Justin

Reply | Threaded
Open this post in threaded view
|

Re: [1/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35337 place tool tip anchor point in the centre rather than the bottom right

Justin Mclean
Administrator
Hi,

1.
> Yes, I think we need more variants.

2.
> Maybe the default tooltip bead should be slightly fatter and have x/y offsets or some other way to dictate the
> relative position.

Which do you prefer 1 or 2 for the current ToolTip?

Either having  a position of combination “left, right, top, bottom, centre”  OR a x and y absolute or % would be easy to implement and not too fat.

Thanks,
Justin
Reply | Threaded
Open this post in threaded view
|

Re: [1/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35337 place tool tip anchor point in the centre rather than the bottom right

Alex Harui-2
I think we need both.

I'm not sure if x,y will work on a row of buttons with different widths.
Maybe the position can be expressed in CSS?

-Alex

On 7/11/17, 11:50 PM, "Justin Mclean" <[hidden email]> wrote:

>Hi,
>
>1.
>> Yes, I think we need more variants.
>
>2.
>> Maybe the default tooltip bead should be slightly fatter and have x/y
>>offsets or some other way to dictate the
>> relative position.
>
>Which do you prefer 1 or 2 for the current ToolTip?
>
>Either having  a position of combination “left, right, top, bottom,
>centre”  OR a x and y absolute or % would be easy to implement and not
>too fat.
>
>Thanks,
>Justin

Reply | Threaded
Open this post in threaded view
|

Re: [1/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35337 place tool tip anchor point in the centre rather than the bottom right

Harbs
In reply to this post by Justin Mclean
FYI:

I noticed today that I was actually using ToolTips and your changes make my buttons very difficult to use as they are significantly obscured by the tooltips. Also, the tooltips are now under the mouse, so the text in not legible until you move the mouse out of the way. On small buttons this makes the tooltip disappear.

The flicker is only an issue because the tooltips are partially obscuring the buttons and your code does not seem to resolve the flickering either. Additionally, mouse-down events when the mouse is over the tooltip are not dispatched on the button.

In short: As it stands, the tooltips are significantly less useable than they were before your changes.

Thanks,
Harbs

> On Jul 12, 2017, at 2:08 AM, Justin Mclean <[hidden email]> wrote:
>
> Hi,
>
>> Why are you assuming that this behavior is wrong?
>
> Because if you have two components side by side and mouse over the first one the tool tip appears below the second one. If you have something on the right of the screen and roll over it you can’t see any tooltip. If you have something at the bottom of the screen and roll over it you can’t see any tooltip.
>
>> Don’t you think a functional change should require discussion?
>
> If you think it does please re open the JIRA and let's discuss.
>
> One possibly would be to have two beads <ToolTipBottmLeftBead> and <ToolTipCentreBead> if it’s not clear what the default placement should be.
>
> Thanks,
> Justin

Reply | Threaded
Open this post in threaded view
|

Re: [1/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35337 place tool tip anchor point in the centre rather than the bottom right

Justin Mclean
Administrator
Hi,

> I noticed today that I was actually using ToolTips and your changes make my buttons very difficult to use as they are significantly obscured by the tooltips. Also, the tooltips are now under the mouse, so the text in not legible until you move the mouse out of the way. On small buttons this makes the tooltip disappear.

Seems like reason enough to revert the position change. I’ll change the bead so you have some control over the position as neither default seems ideal.

> The flicker is only an issue because the tooltips are partially obscuring the buttons and your code does not seem to resolve the flickering either.

The fixes I put were for the AS side. On the JS side there still an issue a labels and mouse over don’t play well together and it happen when you mouse over the text pixel and not the background pixels. We have the same issue when trying to click on a label, this has come up beforehand is due to a change in the SDK  but I couldn’t find where it was discussed.

Thanks,
Justin
Reply | Threaded
Open this post in threaded view
|

Re: [1/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35337 place tool tip anchor point in the centre rather than the bottom right

Harbs

> On Jul 13, 2017, at 7:21 AM, Justin Mclean <[hidden email]> wrote:
>
> Hi,
>
>> I noticed today that I was actually using ToolTips and your changes make my buttons very difficult to use as they are significantly obscured by the tooltips. Also, the tooltips are now under the mouse, so the text in not legible until you move the mouse out of the way. On small buttons this makes the tooltip disappear.
>
> Seems like reason enough to revert the position change. I’ll change the bead so you have some control over the position as neither default seems ideal.

Thanks.

> The flicker is only an issue because the tooltips are partially obscuring the buttons and your code does not seem to resolve the flickering either.
>
> The fixes I put were for the AS side. On the JS side there still an issue a labels and mouse over don’t play well together and it happen when you mouse over the text pixel and not the background pixels. We have the same issue when trying to click on a label, this has come up beforehand is due to a change in the SDK  but I couldn’t find where it was discussed.

Alex’s suggestion to make it “mouse invisible” should resolve this.