Re: [3/3] git commit: [flex-asjs] [refs/heads/develop] - set input type back to text when bead is removed

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [3/3] git commit: [flex-asjs] [refs/heads/develop] - set input type back to text when bead is removed

piotrz
Hi Justin,

Can it be close as part of separate bead ? What actually are you doing here
?

Piotr

2017-06-05 5:19 GMT+02:00 <[hidden email]>:

> set input type back to text when bead is removed
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/0d696541
> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/0d696541
> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/0d696541
>
> Branch: refs/heads/develop
> Commit: 0d69654163d8fe0ae7d027f027fa06bb7d71f4bd
> Parents: 385655a
> Author: Justin Mclean <[hidden email]>
> Authored: Mon Jun 5 13:17:04 2017 +1000
> Committer: Justin Mclean <[hidden email]>
> Committed: Mon Jun 5 13:17:04 2017 +1000
>
> ----------------------------------------------------------------------
>  .../flex/html/accessories/PasswordInputBead.as  | 20 +++++++++++++++-----
>  1 file changed, 15 insertions(+), 5 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/
> 0d696541/frameworks/projects/Basic/src/main/flex/org/
> apache/flex/html/accessories/PasswordInputBead.as
> ----------------------------------------------------------------------
> diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/
> html/accessories/PasswordInputBead.as b/frameworks/projects/Basic/
> src/main/flex/org/apache/flex/html/accessories/PasswordInputBead.as
> index e73822b..4312100 100644
> --- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/
> html/accessories/PasswordInputBead.as
> +++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/
> html/accessories/PasswordInputBead.as
> @@ -68,17 +68,27 @@ package org.apache.flex.html.accessories
>                  */
>                 public function set strand(value:IStrand):void
>                 {
> -                       _strand = value;
> -
>                         COMPILE::SWF
>                         {
> +                               _strand = value;
>                                 IEventDispatcher(value).
> addEventListener("viewChanged",viewChangeHandler);
>                         }
>                         COMPILE::JS
>                         {
> -                               var host:UIBase = value as UIBase;
> -                               var e:HTMLInputElement = host.element as
> HTMLInputElement;
> -                               e.type = 'password';
> +                               var host:UIBase;
> +                               var e:HTMLInputElement;
> +
> +                               if (value !== null) {;
> +                                       host = value as UIBase;
> +                                       e = host.element as
> HTMLInputElement;
> +                                       e.type = 'password';
> +                }
> +                               else {
> +                                       host = _strand as UIBase;
> +                                       e = host.element as
> HTMLInputElement;
> +                    e.type = 'text';
> +                }
> +                               _strand = value;
>                         }
>                 }
>
>
>
Reply | Threaded
Open this post in threaded view
|

Odgovor: [3/3] git commit: [flex-asjs] [refs/heads/develop] - set input type back to text when bead is removed

Silvije Mudri
 Bok na.  

Poslano s pametnog telefona BlackBerry 10.
  Originalna poruka  
Šalje: Piotr Zarzycki
Poslano: ponedjeljak, 5. lipnja 2017. 17:26
Prima: [hidden email]
Odgovor za: [hidden email]
Predmet: Re: [3/3] git commit: [flex-asjs] [refs/heads/develop] - set input type back to text when bead is removed

Hi Justin,

Can it be close as part of separate bead ? What actually are you doing here
?

Piotr

2017-06-05 5:19 GMT+02:00 <[hidden email]>:

> set input type back to text when bead is removed
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/0d696541
> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/0d696541
> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/0d696541
>
> Branch: refs/heads/develop
> Commit: 0d69654163d8fe0ae7d027f027fa06bb7d71f4bd
> Parents: 385655a
> Author: Justin Mclean <[hidden email]>
> Authored: Mon Jun 5 13:17:04 2017 +1000
> Committer: Justin Mclean <[hidden email]>
> Committed: Mon Jun 5 13:17:04 2017 +1000
>
> ----------------------------------------------------------------------
> .../flex/html/accessories/PasswordInputBead.as | 20 +++++++++++++++-----
> 1 file changed, 15 insertions(+), 5 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/
> 0d696541/frameworks/projects/Basic/src/main/flex/org/
> apache/flex/html/accessories/PasswordInputBead.as
> ----------------------------------------------------------------------
> diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/
> html/accessories/PasswordInputBead.as b/frameworks/projects/Basic/
> src/main/flex/org/apache/flex/html/accessories/PasswordInputBead.as
> index e73822b..4312100 100644
> --- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/
> html/accessories/PasswordInputBead.as
> +++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/
> html/accessories/PasswordInputBead.as
> @@ -68,17 +68,27 @@ package org.apache.flex.html.accessories
> */
> public function set strand(value:IStrand):void
> {
> - _strand = value;
> -
> COMPILE::SWF
> {
> + _strand = value;
> IEventDispatcher(value).
> addEventListener("viewChanged",viewChangeHandler);
> }
> COMPILE::JS
> {
> - var host:UIBase = value as UIBase;
> - var e:HTMLInputElement = host.element as
> HTMLInputElement;
> - e.type = 'password';
> + var host:UIBase;
> + var e:HTMLInputElement;
> +
> + if (value !== null) {;
> + host = value as UIBase;
> + e = host.element as
> HTMLInputElement;
> + e.type = 'password';
> + }
> + else {
> + host = _strand as UIBase;
> + e = host.element as
> HTMLInputElement;
> + e.type = 'text';
> + }
> + _strand = value;
> }
> }
>
>
>