Re: git commit: [flex-asjs] [refs/heads/release0.8.0] - Fix for FLEX-35322: NumericStepper layout.

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: git commit: [flex-asjs] [refs/heads/release0.8.0] - Fix for FLEX-35322: NumericStepper layout.

Justin Mclean
Administrator
Hi,

Not 100% sure and I probably not understanding what these methods are doing but perhaps the issue is in isHeightSizedToContent / isWidthSizedToContent.

Does the last line of each function look suspect to anyone else?

return (left === undefined || right === undefined);

return (top === undefined || bottom === undefined);

I would of expected that && be used rather than ||?

Thanks,
Justin

Reply | Threaded
Open this post in threaded view
|

Re: git commit: [flex-asjs] [refs/heads/release0.8.0] - Fix for FLEX-35322: NumericStepper layout.

Harbs
Nope. Looks right to me.

> On Jun 7, 2017, at 3:03 AM, Justin Mclean <[hidden email]> wrote:
>
> Hi,
>
> Not 100% sure and I probably not understanding what these methods are doing but perhaps the issue is in isHeightSizedToContent / isWidthSizedToContent.
>
> Does the last line of each function look suspect to anyone else?
>
> return (left === undefined || right === undefined);
>
> return (top === undefined || bottom === undefined);
>
> I would of expected that && be used rather than ||?
>
> Thanks,
> Justin
>