Re: git commit: [flex-asjs] [refs/heads/tlf] - Temp fix for labels of accordion not working.

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: git commit: [flex-asjs] [refs/heads/tlf] - Temp fix for labels of accordion not working.

piotrz
Hi Yishay,

I think those changes probably should be propagated also to release branch.

Piotr

2017-06-04 10:51 GMT+02:00 <[hidden email]>:

> Repository: flex-asjs
> Updated Branches:
>   refs/heads/tlf 65c599330 -> 608a7b91e
>
>
> Temp fix for labels of accordion not working.
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/608a7b91
> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/608a7b91
> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/608a7b91
>
> Branch: refs/heads/tlf
> Commit: 608a7b91e4742b53a93f8a09037a75f5a8df57a3
> Parents: 65c5993
> Author: DESKTOP-RH4S838\Yishay <[hidden email]>
> Authored: Sun Jun 4 11:50:37 2017 +0300
> Committer: DESKTOP-RH4S838\Yishay <[hidden email]>
> Committed: Sun Jun 4 11:50:37 2017 +0300
>
> ----------------------------------------------------------------------
>  .../org/apache/flex/html/supportClasses/AccordionItemRenderer.as | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/
> 608a7b91/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/
> supportClasses/AccordionItemRenderer.as
> ----------------------------------------------------------------------
> diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/
> html/supportClasses/AccordionItemRenderer.as b/frameworks/projects/Basic/
> src/main/flex/org/apache/flex/html/supportClasses/AccordionItemRenderer.as
> index e1e4b0d..b720f47 100644
> --- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/
> html/supportClasses/AccordionItemRenderer.as
> +++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/
> html/supportClasses/AccordionItemRenderer.as
> @@ -22,6 +22,7 @@ package org.apache.flex.html.supportClasses
>         import org.apache.flex.core.ISelectableItemRenderer;
>         import org.apache.flex.core.IStrand;
>         import org.apache.flex.core.ITitleBarModel;
> +       import org.apache.flex.events.Event;
>         import org.apache.flex.html.Panel;
>         import org.apache.flex.html.TitleBar;
>         import org.apache.flex.html.beads.PanelView;
> @@ -114,7 +115,8 @@ package org.apache.flex.html.supportClasses
>                                 var dataTitleModel:ITitleBarModel =
> dataAsStrand.getBeadByType(ITitleBarModel) as ITitleBarModel;
>                                 if (dataTitleModel)
>                                 {
> -                                       titleBar.model = dataTitleModel;
> +//                                     titleBar.model = dataTitleModel;
> +                                       titleBar.title =
> dataTitleModel.title; // temp fix. The line above should be swapoped with
> this one once databinding works.
>                                 }
>                         }
>                 }
>
>
Reply | Threaded
Open this post in threaded view
|

Re: git commit: [flex-asjs] [refs/heads/tlf] - Temp fix for labels of accordion not working.

Harbs
This fix should not be necessary.

It looks like binding is broken.

Changing the model causes the titleChange event to not be caught by the view. This used to work.

> On Jun 4, 2017, at 12:02 PM, Piotr Zarzycki <[hidden email]> wrote:
>
> Hi Yishay,
>
> I think those changes probably should be propagated also to release branch.
>
> Piotr
>
> 2017-06-04 10:51 GMT+02:00 <[hidden email]>:
>
>> Repository: flex-asjs
>> Updated Branches:
>>  refs/heads/tlf 65c599330 -> 608a7b91e
>>
>>
>> Temp fix for labels of accordion not working.
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/608a7b91
>> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/608a7b91
>> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/608a7b91
>>
>> Branch: refs/heads/tlf
>> Commit: 608a7b91e4742b53a93f8a09037a75f5a8df57a3
>> Parents: 65c5993
>> Author: DESKTOP-RH4S838\Yishay <[hidden email]>
>> Authored: Sun Jun 4 11:50:37 2017 +0300
>> Committer: DESKTOP-RH4S838\Yishay <[hidden email]>
>> Committed: Sun Jun 4 11:50:37 2017 +0300
>>
>> ----------------------------------------------------------------------
>> .../org/apache/flex/html/supportClasses/AccordionItemRenderer.as | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>> ----------------------------------------------------------------------
>>
>>
>> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/
>> 608a7b91/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/
>> supportClasses/AccordionItemRenderer.as
>> ----------------------------------------------------------------------
>> diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/
>> html/supportClasses/AccordionItemRenderer.as b/frameworks/projects/Basic/
>> src/main/flex/org/apache/flex/html/supportClasses/AccordionItemRenderer.as
>> index e1e4b0d..b720f47 100644
>> --- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/
>> html/supportClasses/AccordionItemRenderer.as
>> +++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/
>> html/supportClasses/AccordionItemRenderer.as
>> @@ -22,6 +22,7 @@ package org.apache.flex.html.supportClasses
>>        import org.apache.flex.core.ISelectableItemRenderer;
>>        import org.apache.flex.core.IStrand;
>>        import org.apache.flex.core.ITitleBarModel;
>> +       import org.apache.flex.events.Event;
>>        import org.apache.flex.html.Panel;
>>        import org.apache.flex.html.TitleBar;
>>        import org.apache.flex.html.beads.PanelView;
>> @@ -114,7 +115,8 @@ package org.apache.flex.html.supportClasses
>>                                var dataTitleModel:ITitleBarModel =
>> dataAsStrand.getBeadByType(ITitleBarModel) as ITitleBarModel;
>>                                if (dataTitleModel)
>>                                {
>> -                                       titleBar.model = dataTitleModel;
>> +//                                     titleBar.model = dataTitleModel;
>> +                                       titleBar.title =
>> dataTitleModel.title; // temp fix. The line above should be swapoped with
>> this one once databinding works.
>>                                }
>>                        }
>>                }
>>
>>

Reply | Threaded
Open this post in threaded view
|

Re: git commit: [flex-asjs] [refs/heads/tlf] - Temp fix for labels of accordion not working.

piotrz
Hi Harbs,

Please raise jira and if it is still plan to create some example with Accordion it would be helpful.
I will look into the Binding.

Thanks,
Piotr