Re: git commit: [flex-sdk] [refs/heads/develop] - testing if we can make a release build target without running the tests

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: git commit: [flex-sdk] [refs/heads/develop] - testing if we can make a release build target without running the tests

piotrz
This is one of the commit which causes build fail. What's the plan to fix
that ?

2017-12-30 7:26 GMT+01:00 <[hidden email]>:

> Repository: flex-sdk
> Updated Branches:
>   refs/heads/develop eeb68fcc4 -> 35214ffd3
>
>
> testing if we can make a release build target without running the tests
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/35214ffd
> Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/35214ffd
> Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/35214ffd
>
> Branch: refs/heads/develop
> Commit: 35214ffd3d88ea4eaa255befc693be2b25bca51d
> Parents: eeb68fc
> Author: Justin Mclean <[hidden email]>
> Authored: Sat Dec 30 17:25:46 2017 +1100
> Committer: Justin Mclean <[hidden email]>
> Committed: Sat Dec 30 17:25:46 2017 +1100
>
> ----------------------------------------------------------------------
>  build.xml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/35214ffd/build.xml
> ----------------------------------------------------------------------
> diff --git a/build.xml b/build.xml
> index 66842ec..d3f4781 100644
> --- a/build.xml
> +++ b/build.xml
> @@ -116,6 +116,9 @@
>      <target name="release"
>          depends="check-compile-env,check-runtime-env,check-adobe-
> extension-manager-env,source-release,binary-release,rat-check"
>          description="Creates source and binary kits for Apache Flex."/>
> +
> +    <target name="release-notests" depends="check-compile-env,
> source-release,setup-binary-release,main,frameworks-rsls,
> sample-themes,doc,other.locales,binary-package,
> additional-packages,rat-check"
> +        description="Creates source and binary kits for Apache Flex."/>
>
>      <target name="release-pixelbender"
>          depends="check-compile-env,check-runtime-env,source-
> package-pixelbender,binary-package-pixelbender"
> @@ -1417,7 +1420,7 @@ There are no known issues.
>      <target name="oldcheckintests" depends="dependencychecker-
> framework,checkintests-mustella" description="Run these tests before
> every checkin"/>
>
>      <!-- FixMe: add dependency checker and mobile tests -->
> -    <target name="checkintests" depends="basictests-mustella"
> description="Run these tests before every checkin" />
> +    <target name="checkintests" depends="basictests-mustella"
> description="Run these tests before every checkin" unless="no.checkintests"
> />
>      <!--<target name="checkintests" depends="dependencychecker-
> framework,basictests-mustella,checkintests-mobile" description="Run these
> tests before every checkin"/-->
>
>      <target name="checkintests-mobile" depends="airmobile-basictests-mustella"
> description="Run these tests before every checkin to mobile SDK code"/>
>
>


--

Piotr Zarzycki

Patreon: *https://www.patreon.com/piotrzarzycki
<https://www.patreon.com/piotrzarzycki>*
Reply | Threaded
Open this post in threaded view
|

Re: git commit: [flex-sdk] [refs/heads/develop] - testing if we can make a release build target without running the tests

Justin Mclean
Administrator
Hi,

> This is one of the commit which causes build fail. What's the plan to fix that ?

Odd that change is working fine locally and I can’t see how that would break the build i.e. adding new target that isn’t used.

I’ll look into it.

Thanks,
Justin
Reply | Threaded
Open this post in threaded view
|

Re: git commit: [flex-sdk] [refs/heads/develop] - testing if we can make a release build target without running the tests

Justin Mclean
Administrator
In reply to this post by piotrz
Hi,

> This is one of the commit which causes build fail. What's the plan to fix
> that ?

That commit wasn’t the issue it was the one after that. I’ve pushed a fix and things should be back to normal.

Thanks,
Justin