[VOTE] Release Apache Flex FalconJX 0.8.0 RC1

classic Classic list List threaded Threaded
29 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[VOTE] Release Apache Flex FalconJX 0.8.0 RC1

Alex Harui-2
Hi,

This is vote for the 0.8.0 release of the FalconJX (and Falcon)
compilers.  There is no separate Falcon-only release package at
this time.  The only purpose of the FalconJX packages are to serve as
upstream packages for the FlexJS release.

The release candidate can be found here;
https://dist.apache.org/repos/dist/dev/flex/falcon/0.8.0/rc1/

Before voting please review the section, 'What are the ASF requirements on
approving a release?', at:
http://www.apache.org/dev/release.html#approving-a-release

At a minimum you would be expected to check that:
- MD5 and signed packages are correct
- README, RELEASE_NOTES, NOTICE and LICENSE files are all fine
- That the build script completes successfully
- That you can compile using the results of building the source package

The source package is set up the same way as the repo.  This means that
the results of the build are not the same as the binary package.  The
compiled source package can be used to build FlexJS apps via the command
line and Ant, but not in Flash Builder or other IDEs.  You can test the
source
package by building it, then pointing to it from the source package of the
FlexJS release candidate and building the examples in the FlexJS package.

The binary package is set up as an upstream package for the FlexJS
release.  The most convenient way to use the binary package is to install
a FlexJS SDK via Ant or the Installer.

Please vote to approve this release:
+1 Approve the release
-1 Veto the release (please provide specific comments to why)

This vote will be open for 72 hours or until a result can be called.

The vote passes if there is:
- At least 3 +1 votes from the PMC
- More positive votes than negative votes

Remember that this is a 'beta-quality' release so there
will be many bugs found.  The goal is not to try to find and fix bugs
in the RC, but to make sure we have the packaging right, and enough
functionality that folks will have some success trying to use it.

People who are not in PMC are also encouraged to test out the release and
vote, although their votes will not be binding, they can influence how the
PMC votes.

When voting please indicate what OS, IDE, Flash Player version and AIR
version you tested with.

Please put all discussion about this release in the DISCUSSION thread not
this VOTE thread.

For your convenience there is an ant script that automates the common
steps to validate a release.  Instead of individually downloading the
package and signature files, unzipping, etc, you can instead:
1) create an empty folder,
2) download into that folder this file:
https://dist.apache.org/repos/dist/dev/flex/falcon/0.8.0/rc1/ApproveFalcon.
xml
3) run the script: ant -e -f ApproveFalcon.xml -Drelease.version=0.8.0
-Drc=1

You are not required to use this script, and more testing of the packages
and build results are always encouraged.

Thanks,
Alex Harui

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Flex FalconJX 0.8.0 RC1

Justin Mclean
Administrator
Hi,

+1 (binding) as long as the missing jars are not an issue (see discussion)

I checked on OSX:
- Signatures and hashes correct
- LICENSE and NOTICE correct
- All source files have ASF headers
- No unexpected binary files
- Can compile from source (using mvn)
- Tests pass
- Can use to compile a complex project.  No major issues.

I did note that mvn clean install fails the rat check on 3 files:
  flex-typedefs/google_maps/src/main/patch/google_maps.patch
  flex-typedefs/jquery/src/main/patch/jquery.patch
  flex-typedefs/js/src/main/patch/js.patch

I assume that this can be sorted out one way or another in the next release.

Thanks,
Justin
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Flex FalconJX 0.8.0 RC1

piotrz
In reply to this post by Alex Harui-2
Hi,

+1 (binding)
- Can compile from repository sources by Maven
- Can compile by Ant using ApproveFalcon scrip
- Can compile real world project by Maven using RC1 version of Falcon
- License stuff seems to be ok

Thanks,
Piotr
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Flex FalconJX 0.8.0 RC1

Harbs
In reply to this post by Alex Harui-2
+1
Package https://dist.apache.org/repos/dist/dev/flex/falcon/0.8.0/rc1/apache-flex-falconjx-0.8.0-src.tar.gz
Java 1.8
OS: Mac OS X x86_64 10.10.5
Source kit signatures match: y
Source kit builds: y
README is ok: y
README_JX is ok: y
RELEASE_NOTES is ok: y
RELEASE_NOTES_JX is ok: y
NOTICE is ok: y
LICENSE is ok: y
No unapproved licenses or archives in source package: y
No unapproved binaries in source package: y

Package https://dist.apache.org/repos/dist/dev/flex/falcon/0.8.0/rc1/binaries/apache-flex-falconjx-0.8.0-bin.tar.gz
Binary kit signatures match: y
NOTICE is ok: y
LICENSE is ok: y
No unapproved licenses or files in jars: y
No unapproved licenses or archives in binary package: y
No unapproved binaries in binary package: y

> On Jun 10, 2017, at 12:59 AM, Alex Harui <[hidden email]> wrote:
>
> Hi,
>
> This is vote for the 0.8.0 release of the FalconJX (and Falcon)
> compilers.  There is no separate Falcon-only release package at
> this time.  The only purpose of the FalconJX packages are to serve as
> upstream packages for the FlexJS release.
>
> The release candidate can be found here;
> https://dist.apache.org/repos/dist/dev/flex/falcon/0.8.0/rc1/
>
> Before voting please review the section, 'What are the ASF requirements on
> approving a release?', at:
> http://www.apache.org/dev/release.html#approving-a-release
>
> At a minimum you would be expected to check that:
> - MD5 and signed packages are correct
> - README, RELEASE_NOTES, NOTICE and LICENSE files are all fine
> - That the build script completes successfully
> - That you can compile using the results of building the source package
>
> The source package is set up the same way as the repo.  This means that
> the results of the build are not the same as the binary package.  The
> compiled source package can be used to build FlexJS apps via the command
> line and Ant, but not in Flash Builder or other IDEs.  You can test the
> source
> package by building it, then pointing to it from the source package of the
> FlexJS release candidate and building the examples in the FlexJS package.
>
> The binary package is set up as an upstream package for the FlexJS
> release.  The most convenient way to use the binary package is to install
> a FlexJS SDK via Ant or the Installer.
>
> Please vote to approve this release:
> +1 Approve the release
> -1 Veto the release (please provide specific comments to why)
>
> This vote will be open for 72 hours or until a result can be called.
>
> The vote passes if there is:
> - At least 3 +1 votes from the PMC
> - More positive votes than negative votes
>
> Remember that this is a 'beta-quality' release so there
> will be many bugs found.  The goal is not to try to find and fix bugs
> in the RC, but to make sure we have the packaging right, and enough
> functionality that folks will have some success trying to use it.
>
> People who are not in PMC are also encouraged to test out the release and
> vote, although their votes will not be binding, they can influence how the
> PMC votes.
>
> When voting please indicate what OS, IDE, Flash Player version and AIR
> version you tested with.
>
> Please put all discussion about this release in the DISCUSSION thread not
> this VOTE thread.
>
> For your convenience there is an ant script that automates the common
> steps to validate a release.  Instead of individually downloading the
> package and signature files, unzipping, etc, you can instead:
> 1) create an empty folder,
> 2) download into that folder this file:
> https://dist.apache.org/repos/dist/dev/flex/falcon/0.8.0/rc1/ApproveFalcon.
> xml
> 3) run the script: ant -e -f ApproveFalcon.xml -Drelease.version=0.8.0
> -Drc=1
>
> You are not required to use this script, and more testing of the packages
> and build results are always encouraged.
>
> Thanks,
> Alex Harui
>

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Flex FalconJX 0.8.0 RC1

Christofer Dutz
Hi,

I must report a “-1” (binding) …

but in my case the typedefs are building correctly. Unfortunately, the build produces SNAPSHOT versions and relies on SNAPSHOT versions. We can’t publish this to the Apache Release repo and not have these released to Maven-Central. This is a major issue for me.

Another minor issue would be that I must disable the RAT checks for the falcon build as the flex-typedefs package contains files without the correct license headers (I am reporting a technical issue here). If the flex-typedefs directory should be bundled inside the compiler bundle, then the compiler bundles maven RAT exclusions should be adjusted to work in this scenario. Testing an Apache projects Release Candidate with disabled RAT checks isn’t good.

Chris


Am 11.06.17, 09:26 schrieb "Harbs" <[hidden email]>:

    +1
    Package https://dist.apache.org/repos/dist/dev/flex/falcon/0.8.0/rc1/apache-flex-falconjx-0.8.0-src.tar.gz
    Java 1.8
    OS: Mac OS X x86_64 10.10.5
    Source kit signatures match: y
    Source kit builds: y
    README is ok: y
    README_JX is ok: y
    RELEASE_NOTES is ok: y
    RELEASE_NOTES_JX is ok: y
    NOTICE is ok: y
    LICENSE is ok: y
    No unapproved licenses or archives in source package: y
    No unapproved binaries in source package: y
   
    Package https://dist.apache.org/repos/dist/dev/flex/falcon/0.8.0/rc1/binaries/apache-flex-falconjx-0.8.0-bin.tar.gz
    Binary kit signatures match: y
    NOTICE is ok: y
    LICENSE is ok: y
    No unapproved licenses or files in jars: y
    No unapproved licenses or archives in binary package: y
    No unapproved binaries in binary package: y
   
    > On Jun 10, 2017, at 12:59 AM, Alex Harui <[hidden email]> wrote:
    >
    > Hi,
    >
    > This is vote for the 0.8.0 release of the FalconJX (and Falcon)
    > compilers.  There is no separate Falcon-only release package at
    > this time.  The only purpose of the FalconJX packages are to serve as
    > upstream packages for the FlexJS release.
    >
    > The release candidate can be found here;
    > https://dist.apache.org/repos/dist/dev/flex/falcon/0.8.0/rc1/
    >
    > Before voting please review the section, 'What are the ASF requirements on
    > approving a release?', at:
    > http://www.apache.org/dev/release.html#approving-a-release
    >
    > At a minimum you would be expected to check that:
    > - MD5 and signed packages are correct
    > - README, RELEASE_NOTES, NOTICE and LICENSE files are all fine
    > - That the build script completes successfully
    > - That you can compile using the results of building the source package
    >
    > The source package is set up the same way as the repo.  This means that
    > the results of the build are not the same as the binary package.  The
    > compiled source package can be used to build FlexJS apps via the command
    > line and Ant, but not in Flash Builder or other IDEs.  You can test the
    > source
    > package by building it, then pointing to it from the source package of the
    > FlexJS release candidate and building the examples in the FlexJS package.
    >
    > The binary package is set up as an upstream package for the FlexJS
    > release.  The most convenient way to use the binary package is to install
    > a FlexJS SDK via Ant or the Installer.
    >
    > Please vote to approve this release:
    > +1 Approve the release
    > -1 Veto the release (please provide specific comments to why)
    >
    > This vote will be open for 72 hours or until a result can be called.
    >
    > The vote passes if there is:
    > - At least 3 +1 votes from the PMC
    > - More positive votes than negative votes
    >
    > Remember that this is a 'beta-quality' release so there
    > will be many bugs found.  The goal is not to try to find and fix bugs
    > in the RC, but to make sure we have the packaging right, and enough
    > functionality that folks will have some success trying to use it.
    >
    > People who are not in PMC are also encouraged to test out the release and
    > vote, although their votes will not be binding, they can influence how the
    > PMC votes.
    >
    > When voting please indicate what OS, IDE, Flash Player version and AIR
    > version you tested with.
    >
    > Please put all discussion about this release in the DISCUSSION thread not
    > this VOTE thread.
    >
    > For your convenience there is an ant script that automates the common
    > steps to validate a release.  Instead of individually downloading the
    > package and signature files, unzipping, etc, you can instead:
    > 1) create an empty folder,
    > 2) download into that folder this file:
    > https://dist.apache.org/repos/dist/dev/flex/falcon/0.8.0/rc1/ApproveFalcon.
    > xml
    > 3) run the script: ant -e -f ApproveFalcon.xml -Drelease.version=0.8.0
    > -Drc=1
    >
    > You are not required to use this script, and more testing of the packages
    > and build results are always encouraged.
    >
    > Thanks,
    > Alex Harui
    >
   
   

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Flex FalconJX 0.8.0 RC1

Carlos Rovira
-1 (binding)

For the same reason Chris reported.

Thanks

2017-06-12 11:08 GMT+02:00 Christofer Dutz <[hidden email]>:

> Hi,
>
> I must report a “-1” (binding) …
>
> but in my case the typedefs are building correctly. Unfortunately, the
> build produces SNAPSHOT versions and relies on SNAPSHOT versions. We can’t
> publish this to the Apache Release repo and not have these released to
> Maven-Central. This is a major issue for me.
>
> Another minor issue would be that I must disable the RAT checks for the
> falcon build as the flex-typedefs package contains files without the
> correct license headers (I am reporting a technical issue here). If the
> flex-typedefs directory should be bundled inside the compiler bundle, then
> the compiler bundles maven RAT exclusions should be adjusted to work in
> this scenario. Testing an Apache projects Release Candidate with disabled
> RAT checks isn’t good.
>
> Chris
>
>
> Am 11.06.17, 09:26 schrieb "Harbs" <[hidden email]>:
>
>     +1
>     Package https://dist.apache.org/repos/dist/dev/flex/falcon/0.8.0/
> rc1/apache-flex-falconjx-0.8.0-src.tar.gz
>     Java 1.8
>     OS: Mac OS X x86_64 10.10.5
>     Source kit signatures match: y
>     Source kit builds: y
>     README is ok: y
>     README_JX is ok: y
>     RELEASE_NOTES is ok: y
>     RELEASE_NOTES_JX is ok: y
>     NOTICE is ok: y
>     LICENSE is ok: y
>     No unapproved licenses or archives in source package: y
>     No unapproved binaries in source package: y
>
>     Package https://dist.apache.org/repos/dist/dev/flex/falcon/0.8.0/
> rc1/binaries/apache-flex-falconjx-0.8.0-bin.tar.gz
>     Binary kit signatures match: y
>     NOTICE is ok: y
>     LICENSE is ok: y
>     No unapproved licenses or files in jars: y
>     No unapproved licenses or archives in binary package: y
>     No unapproved binaries in binary package: y
>
>     > On Jun 10, 2017, at 12:59 AM, Alex Harui <[hidden email]>
> wrote:
>     >
>     > Hi,
>     >
>     > This is vote for the 0.8.0 release of the FalconJX (and Falcon)
>     > compilers.  There is no separate Falcon-only release package at
>     > this time.  The only purpose of the FalconJX packages are to serve as
>     > upstream packages for the FlexJS release.
>     >
>     > The release candidate can be found here;
>     > https://dist.apache.org/repos/dist/dev/flex/falcon/0.8.0/rc1/
>     >
>     > Before voting please review the section, 'What are the ASF
> requirements on
>     > approving a release?', at:
>     > http://www.apache.org/dev/release.html#approving-a-release
>     >
>     > At a minimum you would be expected to check that:
>     > - MD5 and signed packages are correct
>     > - README, RELEASE_NOTES, NOTICE and LICENSE files are all fine
>     > - That the build script completes successfully
>     > - That you can compile using the results of building the source
> package
>     >
>     > The source package is set up the same way as the repo.  This means
> that
>     > the results of the build are not the same as the binary package.  The
>     > compiled source package can be used to build FlexJS apps via the
> command
>     > line and Ant, but not in Flash Builder or other IDEs.  You can test
> the
>     > source
>     > package by building it, then pointing to it from the source package
> of the
>     > FlexJS release candidate and building the examples in the FlexJS
> package.
>     >
>     > The binary package is set up as an upstream package for the FlexJS
>     > release.  The most convenient way to use the binary package is to
> install
>     > a FlexJS SDK via Ant or the Installer.
>     >
>     > Please vote to approve this release:
>     > +1 Approve the release
>     > -1 Veto the release (please provide specific comments to why)
>     >
>     > This vote will be open for 72 hours or until a result can be called.
>     >
>     > The vote passes if there is:
>     > - At least 3 +1 votes from the PMC
>     > - More positive votes than negative votes
>     >
>     > Remember that this is a 'beta-quality' release so there
>     > will be many bugs found.  The goal is not to try to find and fix bugs
>     > in the RC, but to make sure we have the packaging right, and enough
>     > functionality that folks will have some success trying to use it.
>     >
>     > People who are not in PMC are also encouraged to test out the
> release and
>     > vote, although their votes will not be binding, they can influence
> how the
>     > PMC votes.
>     >
>     > When voting please indicate what OS, IDE, Flash Player version and
> AIR
>     > version you tested with.
>     >
>     > Please put all discussion about this release in the DISCUSSION
> thread not
>     > this VOTE thread.
>     >
>     > For your convenience there is an ant script that automates the common
>     > steps to validate a release.  Instead of individually downloading the
>     > package and signature files, unzipping, etc, you can instead:
>     > 1) create an empty folder,
>     > 2) download into that folder this file:
>     > https://dist.apache.org/repos/dist/dev/flex/falcon/0.8.0/
> rc1/ApproveFalcon.
>     > xml
>     > 3) run the script: ant -e -f ApproveFalcon.xml
> -Drelease.version=0.8.0
>     > -Drc=1
>     >
>     > You are not required to use this script, and more testing of the
> packages
>     > and build results are always encouraged.
>     >
>     > Thanks,
>     > Alex Harui
>     >
>
>
>
>


--

<http://www.codeoscopic.com>

Carlos Rovira

Director General

M: +34 607 22 60 05

http://www.codeoscopic.com

http://www.avant2.es


Este mensaje se dirige exclusivamente a su destinatario y puede contener
información privilegiada o confidencial. Si ha recibido este mensaje por
error, le rogamos que nos lo comunique inmediatamente por esta misma vía y
proceda a su destrucción.

De la vigente Ley Orgánica de Protección de Datos (15/1999), le comunicamos
que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
S.A. La finalidad de dicho tratamiento es facilitar la prestación del
servicio o información solicitados, teniendo usted derecho de acceso,
rectificación, cancelación y oposición de sus datos dirigiéndose a nuestras
oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
necesaria.
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Flex FalconJX 0.8.0 RC1

Justin Mclean
Administrator
Hi,

Changing to -1 (binding).

I can confirm the tyoedef issue is not due to differences in git version.

My guess (but not confirmed) is that some people may to have the js file file cached and that it has changed recently so the patch no longer applies.

I can confirm that the current js.patch will not apply to the file current file here [1].

Can some mind doing a diff with their version of the file and the version here [1]?

Or posting a hash of the file they have:
$curl https://storage.googleapis.com/google-code-archive-downloads/v2/code.google.com/closureidl/svg.js > svg.js
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  155k  100  155k    0     0  74173      0  0:00:02  0:00:02 --:--:-- 74189
$md5 svg.js
MD5 (svg.js) = 568eb2c11ba33da58eb0471beef76cb9

Thanks,
Justin

1. https://storage.googleapis.com/google-code-archive-downloads/v2/code.google.com/closureidl/svg.js

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Flex FalconJX 0.8.0 RC1

Harbs
/**
 * @param {string} type
 * @param {!EventListener|(function(!Event): (boolean|undefined))| null} listener
 * @param {boolean=} opt_useCapture
 */
SVGElementInstance.prototype.addEventListener = function(type, listener, opt_useCapture){};


/**
 * @param {string} type
 * @param {!EventListener|(function(!Event): (boolean|undefined))| null} listener
 * @param {boolean=} opt_useCapture

function(!Event) has now become function(Event)

I assume this is from the patch. Other than that, it’s identical.

> On Jun 14, 2017, at 5:23 AM, Justin Mclean <[hidden email] <mailto:[hidden email]>> wrote:
>
> Can some mind doing a diff with their version of the file and the version here [1]?

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Flex FalconJX 0.8.0 RC1

Justin Mclean
Administrator
Hi,

> I assume this is from the patch.

Yep that’s in the patch.
/**
* @param {string} type
- * @param {!EventListener|(function(Event): (boolean|undefined))| null} listener
+ * @param {!EventListener|(function(!Event): (boolean|undefined))| null} listener
* @param {boolean=} opt_useCapture
*/
SVGElementInstance.prototype.addEventListener = function(type, listener, opt_useCapture){};

But if that line was already changed wouldn’t the patch fail?

> Other than that, it’s identical.

Which would be odd as the patch removes 100+ lines, all comments I believe. Did you see that?

thanks,
Justin
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Flex FalconJX 0.8.0 RC1

Harbs
Quite frankly, I don’t know how to read patch files, and I don’t know what it’s supposed to be doing.

I’m going to leave this to someone who understands this better than I do to figure out… ;-)

> On Jun 14, 2017, at 12:12 PM, Justin Mclean <[hidden email]> wrote:
>
> Hi,
>
>> I assume this is from the patch.
>
> Yep that’s in the patch.
> /**
> * @param {string} type
> - * @param {!EventListener|(function(Event): (boolean|undefined))| null} listener
> + * @param {!EventListener|(function(!Event): (boolean|undefined))| null} listener
> * @param {boolean=} opt_useCapture
> */
> SVGElementInstance.prototype.addEventListener = function(type, listener, opt_useCapture){};
>
> But if that line was already changed wouldn’t the patch fail?
>
>> Other than that, it’s identical.
>
> Which would be odd as the patch removes 100+ lines, all comments I believe. Did you see that?
>
> thanks,
> Justin

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Flex FalconJX 0.8.0 RC1

Alex Harui-2
In reply to this post by Justin Mclean
I just ran the curl command (sorry if my Outlook has munged the URL).  I
got the same hash.  When I open it up, I see:

/**
 * @param {string} type
 * @param {!EventListener|(function(Event): (boolean|undefined))| null}
listener
 * @param {boolean=} opt_useCapture
 */
SVGElementInstance.prototype.addEventListener = function(type, listener,
opt_useCapture){};

The patch is trying to replace

        (function(Event):


With:

        (function(!Event):


I verified locally that both my Ant and Maven builds from the repos can
successfully download and patch svg.js.  I did a clean before each build
to verify that svg.js was not in the repo working copy folders.


So you are saying that when you use curl to grab that file it already has
"(function(!Event):" in it?  That isn't the case for me.  That is really
strange given the hash was the same.

Very puzzled,
-Alex


On 6/13/17, 7:23 PM, "Justin Mclean" <[hidden email]> wrote:

>Hi,
>
>Changing to -1 (binding).
>
>I can confirm the tyoedef issue is not due to differences in git version.
>
>My guess (but not confirmed) is that some people may to have the js file
>file cached and that it has changed recently so the patch no longer
>applies.
>
>I can confirm that the current js.patch will not apply to the file
>current file here [1].
>
>Can some mind doing a diff with their version of the file and the version
>here [1]?
>
>Or posting a hash of the file they have:
>$curl
>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fstorage.g
>oogleapis.com%2Fgoogle-code-archive-downloads%2Fv2%2Fcode.google.com%2Fclo
>sureidl%2Fsvg.js&data=02%7C01%7C%7C2663b54b26d74c4e011c08d4b2cc5b6c%7Cfa7b
>1b5a7b34438794aed2c178decee1%7C0%7C0%7C636330038163199802&sdata=GzJiK3o9QT
>3TcUiBFDUpKJIYELPlBIWbKHVsuIeIzxs%3D&reserved=0 > svg.js
>  % Total    % Received % Xferd  Average Speed   Time    Time     Time
>Current
>                                 Dload  Upload   Total   Spent    Left
>Speed
>100  155k  100  155k    0     0  74173      0  0:00:02  0:00:02 --:--:--
>74189
>$md5 svg.js
>MD5 (svg.js) = 568eb2c11ba33da58eb0471beef76cb9
>
>Thanks,
>Justin
>
>1.
>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fstorage.g
>oogleapis.com%2Fgoogle-code-archive-downloads%2Fv2%2Fcode.google.com%2Fclo
>sureidl%2Fsvg.js&data=02%7C01%7C%7C2663b54b26d74c4e011c08d4b2cc5b6c%7Cfa7b
>1b5a7b34438794aed2c178decee1%7C0%7C0%7C636330038163199802&sdata=GzJiK3o9QT
>3TcUiBFDUpKJIYELPlBIWbKHVsuIeIzxs%3D&reserved=0
>

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Flex FalconJX 0.8.0 RC1

Greg Dove
Alex, fyi if I delete the target directory inside flex-typedefs (to be sure
it is 'clean', although I am quite sure mvn clean does this also) , then
run mvn clean compile, i get the following in svg.js inside downloads:

/**
 * @param {string} type
 * @param {!EventListener|(function(!Event): (boolean|undefined))| null}
listener
 * @param {boolean=} opt_useCapture
 */
SVGElementInstance.prototype.addEventListener = function(type, listener,
opt_useCapture){};

so for me at least, it does already seem to have the "(function(!Event):"
etc in it.




On Thu, Jun 15, 2017 at 11:09 AM, Alex Harui <[hidden email]>
wrote:

> I just ran the curl command (sorry if my Outlook has munged the URL).  I
> got the same hash.  When I open it up, I see:
>
> /**
>  * @param {string} type
>  * @param {!EventListener|(function(Event): (boolean|undefined))| null}
> listener
>  * @param {boolean=} opt_useCapture
>  */
> SVGElementInstance.prototype.addEventListener = function(type, listener,
> opt_useCapture){};
>
> The patch is trying to replace
>
>         (function(Event):
>
>
> With:
>
>         (function(!Event):
>
>
> I verified locally that both my Ant and Maven builds from the repos can
> successfully download and patch svg.js.  I did a clean before each build
> to verify that svg.js was not in the repo working copy folders.
>
>
> So you are saying that when you use curl to grab that file it already has
> "(function(!Event):" in it?  That isn't the case for me.  That is really
> strange given the hash was the same.
>
> Very puzzled,
> -Alex
>
>
> On 6/13/17, 7:23 PM, "Justin Mclean" <[hidden email]> wrote:
>
> >Hi,
> >
> >Changing to -1 (binding).
> >
> >I can confirm the tyoedef issue is not due to differences in git version.
> >
> >My guess (but not confirmed) is that some people may to have the js file
> >file cached and that it has changed recently so the patch no longer
> >applies.
> >
> >I can confirm that the current js.patch will not apply to the file
> >current file here [1].
> >
> >Can some mind doing a diff with their version of the file and the version
> >here [1]?
> >
> >Or posting a hash of the file they have:
> >$curl
> >https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fstorage.g
> >oogleapis.com%2Fgoogle-code-archive-downloads%2Fv2%2Fcode.google.com
> %2Fclo
> >sureidl%2Fsvg.js&data=02%7C01%7C%7C2663b54b26d74c4e011c08d4b2cc
> 5b6c%7Cfa7b
> >1b5a7b34438794aed2c178decee1%7C0%7C0%7C636330038163199802&
> sdata=GzJiK3o9QT
> >3TcUiBFDUpKJIYELPlBIWbKHVsuIeIzxs%3D&reserved=0 > svg.js
> >  % Total    % Received % Xferd  Average Speed   Time    Time     Time
> >Current
> >                                 Dload  Upload   Total   Spent    Left
> >Speed
> >100  155k  100  155k    0     0  74173      0  0:00:02  0:00:02 --:--:--
> >74189
> >$md5 svg.js
> >MD5 (svg.js) = 568eb2c11ba33da58eb0471beef76cb9
> >
> >Thanks,
> >Justin
> >
> >1.
> >https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fstorage.g
> >oogleapis.com%2Fgoogle-code-archive-downloads%2Fv2%2Fcode.google.com
> %2Fclo
> >sureidl%2Fsvg.js&data=02%7C01%7C%7C2663b54b26d74c4e011c08d4b2cc
> 5b6c%7Cfa7b
> >1b5a7b34438794aed2c178decee1%7C0%7C0%7C636330038163199802&
> sdata=GzJiK3o9QT
> >3TcUiBFDUpKJIYELPlBIWbKHVsuIeIzxs%3D&reserved=0
> >
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Flex FalconJX 0.8.0 RC1

Greg Dove
A possible clue:

I can see the patched file in :
C:\Users\Greg\.m2\repository\.cache\maven-download-plugin



On Thu, Jun 15, 2017 at 11:25 AM, Greg Dove <[hidden email]> wrote:

> Alex, fyi if I delete the target directory inside flex-typedefs (to be
> sure it is 'clean', although I am quite sure mvn clean does this also) ,
> then run mvn clean compile, i get the following in svg.js inside downloads:
>
> /**
>  * @param {string} type
>  * @param {!EventListener|(function(!Event): (boolean|undefined))| null}
> listener
>  * @param {boolean=} opt_useCapture
>  */
> SVGElementInstance.prototype.addEventListener = function(type, listener,
> opt_useCapture){};
>
> so for me at least, it does already seem to have the "(function(!Event):"
> etc in it.
>
>
>
>
> On Thu, Jun 15, 2017 at 11:09 AM, Alex Harui <[hidden email]>
> wrote:
>
>> I just ran the curl command (sorry if my Outlook has munged the URL).  I
>> got the same hash.  When I open it up, I see:
>>
>> /**
>>  * @param {string} type
>>  * @param {!EventListener|(function(Event): (boolean|undefined))| null}
>> listener
>>  * @param {boolean=} opt_useCapture
>>  */
>> SVGElementInstance.prototype.addEventListener = function(type, listener,
>> opt_useCapture){};
>>
>> The patch is trying to replace
>>
>>         (function(Event):
>>
>>
>> With:
>>
>>         (function(!Event):
>>
>>
>> I verified locally that both my Ant and Maven builds from the repos can
>> successfully download and patch svg.js.  I did a clean before each build
>> to verify that svg.js was not in the repo working copy folders.
>>
>>
>> So you are saying that when you use curl to grab that file it already has
>> "(function(!Event):" in it?  That isn't the case for me.  That is really
>> strange given the hash was the same.
>>
>> Very puzzled,
>> -Alex
>>
>>
>> On 6/13/17, 7:23 PM, "Justin Mclean" <[hidden email]> wrote:
>>
>> >Hi,
>> >
>> >Changing to -1 (binding).
>> >
>> >I can confirm the tyoedef issue is not due to differences in git version.
>> >
>> >My guess (but not confirmed) is that some people may to have the js file
>> >file cached and that it has changed recently so the patch no longer
>> >applies.
>> >
>> >I can confirm that the current js.patch will not apply to the file
>> >current file here [1].
>> >
>> >Can some mind doing a diff with their version of the file and the version
>> >here [1]?
>> >
>> >Or posting a hash of the file they have:
>> >$curl
>> ><a href="https://na01.safelinks.protection.outlook.com/?url=https%">https://na01.safelinks.protection.outlook.com/?url=https%
>> 3A%2F%2Fstorage.g
>> >oogleapis.com%2Fgoogle-code-archive-downloads%2Fv2%2Fcode.google.com
>> %2Fclo
>> >sureidl%2Fsvg.js&data=02%7C01%7C%7C2663b54b26d74c4e011c08d4
>> b2cc5b6c%7Cfa7b
>> >1b5a7b34438794aed2c178decee1%7C0%7C0%7C636330038163199802&s
>> data=GzJiK3o9QT
>> >3TcUiBFDUpKJIYELPlBIWbKHVsuIeIzxs%3D&reserved=0 > svg.js
>> >  % Total    % Received % Xferd  Average Speed   Time    Time     Time
>> >Current
>> >                                 Dload  Upload   Total   Spent    Left
>> >Speed
>> >100  155k  100  155k    0     0  74173      0  0:00:02  0:00:02 --:--:--
>> >74189
>> >$md5 svg.js
>> >MD5 (svg.js) = 568eb2c11ba33da58eb0471beef76cb9
>> >
>> >Thanks,
>> >Justin
>> >
>> >1.
>> ><a href="https://na01.safelinks.protection.outlook.com/?url=https%">https://na01.safelinks.protection.outlook.com/?url=https%
>> 3A%2F%2Fstorage.g
>> >oogleapis.com%2Fgoogle-code-archive-downloads%2Fv2%2Fcode.google.com
>> %2Fclo
>> >sureidl%2Fsvg.js&data=02%7C01%7C%7C2663b54b26d74c4e011c08d4
>> b2cc5b6c%7Cfa7b
>> >1b5a7b34438794aed2c178decee1%7C0%7C0%7C636330038163199802&s
>> data=GzJiK3o9QT
>> >3TcUiBFDUpKJIYELPlBIWbKHVsuIeIzxs%3D&reserved=0
>> >
>>
>>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Flex FalconJX 0.8.0 RC1

Greg Dove
I just manually emptied the file cache in .m2\repository\.
cache\maven-download-plugin

And typedefs built fine via maven.
So my guess is that the download plugin is caching the files after they
have been patched and next time it is 'downloading' the patched file


On Thu, Jun 15, 2017 at 11:40 AM, Greg Dove <[hidden email]> wrote:

> A possible clue:
>
> I can see the patched file in :
> C:\Users\Greg\.m2\repository\.cache\maven-download-plugin
>
>
>
> On Thu, Jun 15, 2017 at 11:25 AM, Greg Dove <[hidden email]> wrote:
>
>> Alex, fyi if I delete the target directory inside flex-typedefs (to be
>> sure it is 'clean', although I am quite sure mvn clean does this also) ,
>> then run mvn clean compile, i get the following in svg.js inside downloads:
>>
>> /**
>>  * @param {string} type
>>  * @param {!EventListener|(function(!Event): (boolean|undefined))| null}
>> listener
>>  * @param {boolean=} opt_useCapture
>>  */
>> SVGElementInstance.prototype.addEventListener = function(type, listener,
>> opt_useCapture){};
>>
>> so for me at least, it does already seem to have the "(function(!Event):"
>> etc in it.
>>
>>
>>
>>
>> On Thu, Jun 15, 2017 at 11:09 AM, Alex Harui <[hidden email]>
>> wrote:
>>
>>> I just ran the curl command (sorry if my Outlook has munged the URL).  I
>>> got the same hash.  When I open it up, I see:
>>>
>>> /**
>>>  * @param {string} type
>>>  * @param {!EventListener|(function(Event): (boolean|undefined))| null}
>>> listener
>>>  * @param {boolean=} opt_useCapture
>>>  */
>>> SVGElementInstance.prototype.addEventListener = function(type, listener,
>>> opt_useCapture){};
>>>
>>> The patch is trying to replace
>>>
>>>         (function(Event):
>>>
>>>
>>> With:
>>>
>>>         (function(!Event):
>>>
>>>
>>> I verified locally that both my Ant and Maven builds from the repos can
>>> successfully download and patch svg.js.  I did a clean before each build
>>> to verify that svg.js was not in the repo working copy folders.
>>>
>>>
>>> So you are saying that when you use curl to grab that file it already has
>>> "(function(!Event):" in it?  That isn't the case for me.  That is really
>>> strange given the hash was the same.
>>>
>>> Very puzzled,
>>> -Alex
>>>
>>>
>>> On 6/13/17, 7:23 PM, "Justin Mclean" <[hidden email]> wrote:
>>>
>>> >Hi,
>>> >
>>> >Changing to -1 (binding).
>>> >
>>> >I can confirm the tyoedef issue is not due to differences in git
>>> version.
>>> >
>>> >My guess (but not confirmed) is that some people may to have the js file
>>> >file cached and that it has changed recently so the patch no longer
>>> >applies.
>>> >
>>> >I can confirm that the current js.patch will not apply to the file
>>> >current file here [1].
>>> >
>>> >Can some mind doing a diff with their version of the file and the
>>> version
>>> >here [1]?
>>> >
>>> >Or posting a hash of the file they have:
>>> >$curl
>>> >https://na01.safelinks.protection.outlook.com/?url=https%3A
>>> %2F%2Fstorage.g
>>> >oogleapis.com%2Fgoogle-code-archive-downloads%2Fv2%2Fcode.google.com
>>> %2Fclo
>>> >sureidl%2Fsvg.js&data=02%7C01%7C%7C2663b54b26d74c4e011c08d4
>>> b2cc5b6c%7Cfa7b
>>> >1b5a7b34438794aed2c178decee1%7C0%7C0%7C636330038163199802&s
>>> data=GzJiK3o9QT
>>> >3TcUiBFDUpKJIYELPlBIWbKHVsuIeIzxs%3D&reserved=0 > svg.js
>>> >  % Total    % Received % Xferd  Average Speed   Time    Time     Time
>>> >Current
>>> >                                 Dload  Upload   Total   Spent    Left
>>> >Speed
>>> >100  155k  100  155k    0     0  74173      0  0:00:02  0:00:02 --:--:--
>>> >74189
>>> >$md5 svg.js
>>> >MD5 (svg.js) = 568eb2c11ba33da58eb0471beef76cb9
>>> >
>>> >Thanks,
>>> >Justin
>>> >
>>> >1.
>>> >https://na01.safelinks.protection.outlook.com/?url=https%3A
>>> %2F%2Fstorage.g
>>> >oogleapis.com%2Fgoogle-code-archive-downloads%2Fv2%2Fcode.google.com
>>> %2Fclo
>>> >sureidl%2Fsvg.js&data=02%7C01%7C%7C2663b54b26d74c4e011c08d4
>>> b2cc5b6c%7Cfa7b
>>> >1b5a7b34438794aed2c178decee1%7C0%7C0%7C636330038163199802&s
>>> data=GzJiK3o9QT
>>> >3TcUiBFDUpKJIYELPlBIWbKHVsuIeIzxs%3D&reserved=0
>>> >
>>>
>>>
>>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Flex FalconJX 0.8.0 RC1

Alex Harui-2
In reply to this post by Greg Dove
Greg,

The Maven build will download and patch the svg.js file so when I look at
my copy after running "mvn clean install", svg.js does have
"function(!Event)" as it should.  IOW, the Ant and Maven build should
download svg.js with "function(Event)" and change it to
"function(!Event)".  It happens fast so I don't know how to interrupt the
build to see what actually gets downloaded.  I believe Justin is saying
that the initial download already has "function(!Event)" but it doesn't
for me.

If folks are trying to build flex-typedefs via Maven from inside the
FalconJX RC1 source package, I'm not sure that's ever been tried.  That
could cause the patch to fail as the flex-typedefs folder is nested one
level.  I moved the flex-typedefs folder outside of the FalconJX folder
and Maven worked for me.

Thanks,
-Alex

On 6/14/17, 4:25 PM, "Greg Dove" <[hidden email]> wrote:

>Alex, fyi if I delete the target directory inside flex-typedefs (to be
>sure
>it is 'clean', although I am quite sure mvn clean does this also) , then
>run mvn clean compile, i get the following in svg.js inside downloads:
>
>/**
> * @param {string} type
> * @param {!EventListener|(function(!Event): (boolean|undefined))| null}
>listener
> * @param {boolean=} opt_useCapture
> */
>SVGElementInstance.prototype.addEventListener = function(type, listener,
>opt_useCapture){};
>
>so for me at least, it does already seem to have the "(function(!Event):"
>etc in it.
>
>
>
>
>On Thu, Jun 15, 2017 at 11:09 AM, Alex Harui <[hidden email]>
>wrote:
>
>> I just ran the curl command (sorry if my Outlook has munged the URL).  I
>> got the same hash.  When I open it up, I see:
>>
>> /**
>>  * @param {string} type
>>  * @param {!EventListener|(function(Event): (boolean|undefined))| null}
>> listener
>>  * @param {boolean=} opt_useCapture
>>  */
>> SVGElementInstance.prototype.addEventListener = function(type, listener,
>> opt_useCapture){};
>>
>> The patch is trying to replace
>>
>>         (function(Event):
>>
>>
>> With:
>>
>>         (function(!Event):
>>
>>
>> I verified locally that both my Ant and Maven builds from the repos can
>> successfully download and patch svg.js.  I did a clean before each build
>> to verify that svg.js was not in the repo working copy folders.
>>
>>
>> So you are saying that when you use curl to grab that file it already
>>has
>> "(function(!Event):" in it?  That isn't the case for me.  That is really
>> strange given the hash was the same.
>>
>> Very puzzled,
>> -Alex
>>
>>
>> On 6/13/17, 7:23 PM, "Justin Mclean" <[hidden email]> wrote:
>>
>> >Hi,
>> >
>> >Changing to -1 (binding).
>> >
>> >I can confirm the tyoedef issue is not due to differences in git
>>version.
>> >
>> >My guess (but not confirmed) is that some people may to have the js
>>file
>> >file cached and that it has changed recently so the patch no longer
>> >applies.
>> >
>> >I can confirm that the current js.patch will not apply to the file
>> >current file here [1].
>> >
>> >Can some mind doing a diff with their version of the file and the
>>version
>> >here [1]?
>> >
>> >Or posting a hash of the file they have:
>> >$curl
>> >https://na01.safelinks.protection.outlook.com/?url=
>> https%3A%2F%2Fstorage.g
>> >oogleapis.com%2Fgoogle-code-archive-downloads%2Fv2%2Fcode.google.com
>> %2Fclo
>> >sureidl%2Fsvg.js&data=02%7C01%7C%7C2663b54b26d74c4e011c08d4b2cc
>> 5b6c%7Cfa7b
>> >1b5a7b34438794aed2c178decee1%7C0%7C0%7C636330038163199802&
>> sdata=GzJiK3o9QT
>> >3TcUiBFDUpKJIYELPlBIWbKHVsuIeIzxs%3D&reserved=0 > svg.js
>> >  % Total    % Received % Xferd  Average Speed   Time    Time     Time
>> >Current
>> >                                 Dload  Upload   Total   Spent    Left
>> >Speed
>> >100  155k  100  155k    0     0  74173      0  0:00:02  0:00:02
>>--:--:--
>> >74189
>> >$md5 svg.js
>> >MD5 (svg.js) = 568eb2c11ba33da58eb0471beef76cb9
>> >
>> >Thanks,
>> >Justin
>> >
>> >1.
>> >https://na01.safelinks.protection.outlook.com/?url=
>> https%3A%2F%2Fstorage.g
>> >oogleapis.com%2Fgoogle-code-archive-downloads%2Fv2%2Fcode.google.com
>> %2Fclo
>> >sureidl%2Fsvg.js&data=02%7C01%7C%7C2663b54b26d74c4e011c08d4b2cc
>> 5b6c%7Cfa7b
>> >1b5a7b34438794aed2c178decee1%7C0%7C0%7C636330038163199802&
>> sdata=GzJiK3o9QT
>> >3TcUiBFDUpKJIYELPlBIWbKHVsuIeIzxs%3D&reserved=0
>> >
>>
>>

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Flex FalconJX 0.8.0 RC1

Greg Dove
Yeah, I think this might be some caching of the downloaded file and
possibly is not a reliable repro.
I just checked now and the cached file for svg.js in my .m2\repository\.
cache\maven-download-plugin after my latest build is not patched. But it
definitely was before. So it might be a bit 'random'
Perhaps this can be avoided by some setting in the pom for the download
plugin or by copying the downloaded file and patching it in a different
location.

Whether this happens might simply depend on how quickly maven-download-plugin
caches the downloaded file and whether or not it has already been patched
when it does so. This could account for why some people seem to have
experienced this problem and others have not (with the maven typedefs
build).




On Thu, Jun 15, 2017 at 11:57 AM, Alex Harui <[hidden email]>
wrote:

> Greg,
>
> The Maven build will download and patch the svg.js file so when I look at
> my copy after running "mvn clean install", svg.js does have
> "function(!Event)" as it should.  IOW, the Ant and Maven build should
> download svg.js with "function(Event)" and change it to
> "function(!Event)".  It happens fast so I don't know how to interrupt the
> build to see what actually gets downloaded.  I believe Justin is saying
> that the initial download already has "function(!Event)" but it doesn't
> for me.
>
> If folks are trying to build flex-typedefs via Maven from inside the
> FalconJX RC1 source package, I'm not sure that's ever been tried.  That
> could cause the patch to fail as the flex-typedefs folder is nested one
> level.  I moved the flex-typedefs folder outside of the FalconJX folder
> and Maven worked for me.
>
> Thanks,
> -Alex
>
> On 6/14/17, 4:25 PM, "Greg Dove" <[hidden email]> wrote:
>
> >Alex, fyi if I delete the target directory inside flex-typedefs (to be
> >sure
> >it is 'clean', although I am quite sure mvn clean does this also) , then
> >run mvn clean compile, i get the following in svg.js inside downloads:
> >
> >/**
> > * @param {string} type
> > * @param {!EventListener|(function(!Event): (boolean|undefined))| null}
> >listener
> > * @param {boolean=} opt_useCapture
> > */
> >SVGElementInstance.prototype.addEventListener = function(type, listener,
> >opt_useCapture){};
> >
> >so for me at least, it does already seem to have the "(function(!Event):"
> >etc in it.
> >
> >
> >
> >
> >On Thu, Jun 15, 2017 at 11:09 AM, Alex Harui <[hidden email]>
> >wrote:
> >
> >> I just ran the curl command (sorry if my Outlook has munged the URL).  I
> >> got the same hash.  When I open it up, I see:
> >>
> >> /**
> >>  * @param {string} type
> >>  * @param {!EventListener|(function(Event): (boolean|undefined))| null}
> >> listener
> >>  * @param {boolean=} opt_useCapture
> >>  */
> >> SVGElementInstance.prototype.addEventListener = function(type,
> listener,
> >> opt_useCapture){};
> >>
> >> The patch is trying to replace
> >>
> >>         (function(Event):
> >>
> >>
> >> With:
> >>
> >>         (function(!Event):
> >>
> >>
> >> I verified locally that both my Ant and Maven builds from the repos can
> >> successfully download and patch svg.js.  I did a clean before each build
> >> to verify that svg.js was not in the repo working copy folders.
> >>
> >>
> >> So you are saying that when you use curl to grab that file it already
> >>has
> >> "(function(!Event):" in it?  That isn't the case for me.  That is really
> >> strange given the hash was the same.
> >>
> >> Very puzzled,
> >> -Alex
> >>
> >>
> >> On 6/13/17, 7:23 PM, "Justin Mclean" <[hidden email]> wrote:
> >>
> >> >Hi,
> >> >
> >> >Changing to -1 (binding).
> >> >
> >> >I can confirm the tyoedef issue is not due to differences in git
> >>version.
> >> >
> >> >My guess (but not confirmed) is that some people may to have the js
> >>file
> >> >file cached and that it has changed recently so the patch no longer
> >> >applies.
> >> >
> >> >I can confirm that the current js.patch will not apply to the file
> >> >current file here [1].
> >> >
> >> >Can some mind doing a diff with their version of the file and the
> >>version
> >> >here [1]?
> >> >
> >> >Or posting a hash of the file they have:
> >> >$curl
> >> >https://na01.safelinks.protection.outlook.com/?url=
> >> https%3A%2F%2Fstorage.g
> >> >oogleapis.com%2Fgoogle-code-archive-downloads%2Fv2%2Fcode.google.com
> >> %2Fclo
> >> >sureidl%2Fsvg.js&data=02%7C01%7C%7C2663b54b26d74c4e011c08d4b2cc
> >> 5b6c%7Cfa7b
> >> >1b5a7b34438794aed2c178decee1%7C0%7C0%7C636330038163199802&
> >> sdata=GzJiK3o9QT
> >> >3TcUiBFDUpKJIYELPlBIWbKHVsuIeIzxs%3D&reserved=0 > svg.js
> >> >  % Total    % Received % Xferd  Average Speed   Time    Time     Time
> >> >Current
> >> >                                 Dload  Upload   Total   Spent    Left
> >> >Speed
> >> >100  155k  100  155k    0     0  74173      0  0:00:02  0:00:02
> >>--:--:--
> >> >74189
> >> >$md5 svg.js
> >> >MD5 (svg.js) = 568eb2c11ba33da58eb0471beef76cb9
> >> >
> >> >Thanks,
> >> >Justin
> >> >
> >> >1.
> >> >https://na01.safelinks.protection.outlook.com/?url=
> >> https%3A%2F%2Fstorage.g
> >> >oogleapis.com%2Fgoogle-code-archive-downloads%2Fv2%2Fcode.google.com
> >> %2Fclo
> >> >sureidl%2Fsvg.js&data=02%7C01%7C%7C2663b54b26d74c4e011c08d4b2cc
> >> 5b6c%7Cfa7b
> >> >1b5a7b34438794aed2c178decee1%7C0%7C0%7C636330038163199802&
> >> sdata=GzJiK3o9QT
> >> >3TcUiBFDUpKJIYELPlBIWbKHVsuIeIzxs%3D&reserved=0
> >> >
> >>
> >>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Flex FalconJX 0.8.0 RC1

Alex Harui-2
In reply to this post by Greg Dove
That's interesting.  But now that you've run Maven again, what version of
svg.js got cached?  The svg.js in my cache does need patching.

-Alex

On 6/14/17, 4:54 PM, "Greg Dove" <[hidden email]> wrote:

>I just manually emptied the file cache in .m2\repository\.
>cache\maven-download-plugin
>
>And typedefs built fine via maven.
>So my guess is that the download plugin is caching the files after they
>have been patched and next time it is 'downloading' the patched file
>
>
>On Thu, Jun 15, 2017 at 11:40 AM, Greg Dove <[hidden email]> wrote:
>
>> A possible clue:
>>
>> I can see the patched file in :
>> C:\Users\Greg\.m2\repository\.cache\maven-download-plugin
>>
>>
>>
>> On Thu, Jun 15, 2017 at 11:25 AM, Greg Dove <[hidden email]> wrote:
>>
>>> Alex, fyi if I delete the target directory inside flex-typedefs (to be
>>> sure it is 'clean', although I am quite sure mvn clean does this also)
>>>,
>>> then run mvn clean compile, i get the following in svg.js inside
>>>downloads:
>>>
>>> /**
>>>  * @param {string} type
>>>  * @param {!EventListener|(function(!Event): (boolean|undefined))|
>>>null}
>>> listener
>>>  * @param {boolean=} opt_useCapture
>>>  */
>>> SVGElementInstance.prototype.addEventListener = function(type,
>>>listener,
>>> opt_useCapture){};
>>>
>>> so for me at least, it does already seem to have the
>>>"(function(!Event):"
>>> etc in it.
>>>
>>>
>>>
>>>
>>> On Thu, Jun 15, 2017 at 11:09 AM, Alex Harui <[hidden email]>
>>> wrote:
>>>
>>>> I just ran the curl command (sorry if my Outlook has munged the URL).
>>>> I
>>>> got the same hash.  When I open it up, I see:
>>>>
>>>> /**
>>>>  * @param {string} type
>>>>  * @param {!EventListener|(function(Event): (boolean|undefined))|
>>>>null}
>>>> listener
>>>>  * @param {boolean=} opt_useCapture
>>>>  */
>>>> SVGElementInstance.prototype.addEventListener = function(type,
>>>>listener,
>>>> opt_useCapture){};
>>>>
>>>> The patch is trying to replace
>>>>
>>>>         (function(Event):
>>>>
>>>>
>>>> With:
>>>>
>>>>         (function(!Event):
>>>>
>>>>
>>>> I verified locally that both my Ant and Maven builds from the repos
>>>>can
>>>> successfully download and patch svg.js.  I did a clean before each
>>>>build
>>>> to verify that svg.js was not in the repo working copy folders.
>>>>
>>>>
>>>> So you are saying that when you use curl to grab that file it already
>>>>has
>>>> "(function(!Event):" in it?  That isn't the case for me.  That is
>>>>really
>>>> strange given the hash was the same.
>>>>
>>>> Very puzzled,
>>>> -Alex
>>>>
>>>>
>>>> On 6/13/17, 7:23 PM, "Justin Mclean" <[hidden email]> wrote:
>>>>
>>>> >Hi,
>>>> >
>>>> >Changing to -1 (binding).
>>>> >
>>>> >I can confirm the tyoedef issue is not due to differences in git
>>>> version.
>>>> >
>>>> >My guess (but not confirmed) is that some people may to have the js
>>>>file
>>>> >file cached and that it has changed recently so the patch no longer
>>>> >applies.
>>>> >
>>>> >I can confirm that the current js.patch will not apply to the file
>>>> >current file here [1].
>>>> >
>>>> >Can some mind doing a diff with their version of the file and the
>>>> version
>>>> >here [1]?
>>>> >
>>>> >Or posting a hash of the file they have:
>>>> >$curl
>>>> >https://na01.safelinks.protection.outlook.com/?url=https%3A
>>>> %2F%2Fstorage.g
>>>> >oogleapis.com%2Fgoogle-code-archive-downloads%2Fv2%2Fcode.google.com
>>>> %2Fclo
>>>> >sureidl%2Fsvg.js&data=02%7C01%7C%7C2663b54b26d74c4e011c08d4
>>>> b2cc5b6c%7Cfa7b
>>>> >1b5a7b34438794aed2c178decee1%7C0%7C0%7C636330038163199802&s
>>>> data=GzJiK3o9QT
>>>> >3TcUiBFDUpKJIYELPlBIWbKHVsuIeIzxs%3D&reserved=0 > svg.js
>>>> >  % Total    % Received % Xferd  Average Speed   Time    Time
>>>>Time
>>>> >Current
>>>> >                                 Dload  Upload   Total   Spent
>>>>Left
>>>> >Speed
>>>> >100  155k  100  155k    0     0  74173      0  0:00:02  0:00:02
>>>>--:--:--
>>>> >74189
>>>> >$md5 svg.js
>>>> >MD5 (svg.js) = 568eb2c11ba33da58eb0471beef76cb9
>>>> >
>>>> >Thanks,
>>>> >Justin
>>>> >
>>>> >1.
>>>> >https://na01.safelinks.protection.outlook.com/?url=https%3A
>>>> %2F%2Fstorage.g
>>>> >oogleapis.com%2Fgoogle-code-archive-downloads%2Fv2%2Fcode.google.com
>>>> %2Fclo
>>>> >sureidl%2Fsvg.js&data=02%7C01%7C%7C2663b54b26d74c4e011c08d4
>>>> b2cc5b6c%7Cfa7b
>>>> >1b5a7b34438794aed2c178decee1%7C0%7C0%7C636330038163199802&s
>>>> data=GzJiK3o9QT
>>>> >3TcUiBFDUpKJIYELPlBIWbKHVsuIeIzxs%3D&reserved=0
>>>> >
>>>>
>>>>
>>>
>>

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Flex FalconJX 0.8.0 RC1

Greg Dove
"But now that you've run Maven again, what version of
svg.js got cached?  The svg.js in my cache does need patching."

I think we crossed email replies because I already added comments about
that -see my previous post if you did not already.

To verify, I copied the downloaded and patched version of svg.js into the
cache, overwriting the last cached version, which was unpatched, and I can
repro the exact same error that I had before. I can only assure you I *did
not* do this originally :)
What I suggested is speculation, but I cannot see how else this could
happen.

So I think the resolution should either be to a) avoid using the download
plugin file cache somehow - or b) to patch a copy of the downloaded files
in a different temp location other than the original download location. I'm
afraid I don't know how to do either in maven at this point.
For now I am happy to find something that seems to 'fix' the issues I was
having with maven typedefs build. fwiw I also had a similar issue with the
googlemaps patch (only during recently builds) , it was the same type of
thing and was no longer apparent after emptying the same file cache.




On Thu, Jun 15, 2017 at 12:07 PM, Alex Harui <[hidden email]>
wrote:

> That's interesting.  But now that you've run Maven again, what version of
> svg.js got cached?  The svg.js in my cache does need patching.
>
> -Alex
>
> On 6/14/17, 4:54 PM, "Greg Dove" <[hidden email]> wrote:
>
> >I just manually emptied the file cache in .m2\repository\.
> >cache\maven-download-plugin
> >
> >And typedefs built fine via maven.
> >So my guess is that the download plugin is caching the files after they
> >have been patched and next time it is 'downloading' the patched file
> >
> >
> >On Thu, Jun 15, 2017 at 11:40 AM, Greg Dove <[hidden email]> wrote:
> >
> >> A possible clue:
> >>
> >> I can see the patched file in :
> >> C:\Users\Greg\.m2\repository\.cache\maven-download-plugin
> >>
> >>
> >>
> >> On Thu, Jun 15, 2017 at 11:25 AM, Greg Dove <[hidden email]>
> wrote:
> >>
> >>> Alex, fyi if I delete the target directory inside flex-typedefs (to be
> >>> sure it is 'clean', although I am quite sure mvn clean does this also)
> >>>,
> >>> then run mvn clean compile, i get the following in svg.js inside
> >>>downloads:
> >>>
> >>> /**
> >>>  * @param {string} type
> >>>  * @param {!EventListener|(function(!Event): (boolean|undefined))|
> >>>null}
> >>> listener
> >>>  * @param {boolean=} opt_useCapture
> >>>  */
> >>> SVGElementInstance.prototype.addEventListener = function(type,
> >>>listener,
> >>> opt_useCapture){};
> >>>
> >>> so for me at least, it does already seem to have the
> >>>"(function(!Event):"
> >>> etc in it.
> >>>
> >>>
> >>>
> >>>
> >>> On Thu, Jun 15, 2017 at 11:09 AM, Alex Harui <[hidden email]
> >
> >>> wrote:
> >>>
> >>>> I just ran the curl command (sorry if my Outlook has munged the URL).
> >>>> I
> >>>> got the same hash.  When I open it up, I see:
> >>>>
> >>>> /**
> >>>>  * @param {string} type
> >>>>  * @param {!EventListener|(function(Event): (boolean|undefined))|
> >>>>null}
> >>>> listener
> >>>>  * @param {boolean=} opt_useCapture
> >>>>  */
> >>>> SVGElementInstance.prototype.addEventListener = function(type,
> >>>>listener,
> >>>> opt_useCapture){};
> >>>>
> >>>> The patch is trying to replace
> >>>>
> >>>>         (function(Event):
> >>>>
> >>>>
> >>>> With:
> >>>>
> >>>>         (function(!Event):
> >>>>
> >>>>
> >>>> I verified locally that both my Ant and Maven builds from the repos
> >>>>can
> >>>> successfully download and patch svg.js.  I did a clean before each
> >>>>build
> >>>> to verify that svg.js was not in the repo working copy folders.
> >>>>
> >>>>
> >>>> So you are saying that when you use curl to grab that file it already
> >>>>has
> >>>> "(function(!Event):" in it?  That isn't the case for me.  That is
> >>>>really
> >>>> strange given the hash was the same.
> >>>>
> >>>> Very puzzled,
> >>>> -Alex
> >>>>
> >>>>
> >>>> On 6/13/17, 7:23 PM, "Justin Mclean" <[hidden email]>
> wrote:
> >>>>
> >>>> >Hi,
> >>>> >
> >>>> >Changing to -1 (binding).
> >>>> >
> >>>> >I can confirm the tyoedef issue is not due to differences in git
> >>>> version.
> >>>> >
> >>>> >My guess (but not confirmed) is that some people may to have the js
> >>>>file
> >>>> >file cached and that it has changed recently so the patch no longer
> >>>> >applies.
> >>>> >
> >>>> >I can confirm that the current js.patch will not apply to the file
> >>>> >current file here [1].
> >>>> >
> >>>> >Can some mind doing a diff with their version of the file and the
> >>>> version
> >>>> >here [1]?
> >>>> >
> >>>> >Or posting a hash of the file they have:
> >>>> >$curl
> >>>> >https://na01.safelinks.protection.outlook.com/?url=https%3A
> >>>> %2F%2Fstorage.g
> >>>> >oogleapis.com%2Fgoogle-code-archive-downloads%2Fv2%2Fcode.google.com
> >>>> %2Fclo
> >>>> >sureidl%2Fsvg.js&data=02%7C01%7C%7C2663b54b26d74c4e011c08d4
> >>>> b2cc5b6c%7Cfa7b
> >>>> >1b5a7b34438794aed2c178decee1%7C0%7C0%7C636330038163199802&s
> >>>> data=GzJiK3o9QT
> >>>> >3TcUiBFDUpKJIYELPlBIWbKHVsuIeIzxs%3D&reserved=0 > svg.js
> >>>> >  % Total    % Received % Xferd  Average Speed   Time    Time
> >>>>Time
> >>>> >Current
> >>>> >                                 Dload  Upload   Total   Spent
> >>>>Left
> >>>> >Speed
> >>>> >100  155k  100  155k    0     0  74173      0  0:00:02  0:00:02
> >>>>--:--:--
> >>>> >74189
> >>>> >$md5 svg.js
> >>>> >MD5 (svg.js) = 568eb2c11ba33da58eb0471beef76cb9
> >>>> >
> >>>> >Thanks,
> >>>> >Justin
> >>>> >
> >>>> >1.
> >>>> >https://na01.safelinks.protection.outlook.com/?url=https%3A
> >>>> %2F%2Fstorage.g
> >>>> >oogleapis.com%2Fgoogle-code-archive-downloads%2Fv2%2Fcode.google.com
> >>>> %2Fclo
> >>>> >sureidl%2Fsvg.js&data=02%7C01%7C%7C2663b54b26d74c4e011c08d4
> >>>> b2cc5b6c%7Cfa7b
> >>>> >1b5a7b34438794aed2c178decee1%7C0%7C0%7C636330038163199802&s
> >>>> data=GzJiK3o9QT
> >>>> >3TcUiBFDUpKJIYELPlBIWbKHVsuIeIzxs%3D&reserved=0
> >>>> >
> >>>>
> >>>>
> >>>
> >>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Flex FalconJX 0.8.0 RC1

piotrz
Hi Greg,

In your points "a" and "b" I'm not sure what do you mean.

If option a - mean avoid caching svg.js file - It is not a problem I know how to do this for this file and it can be downloaded for each build.

Option b) We are downloading this file to target/downloads/svg.js - Do you mean changing that location and patch that file in the new location ?

Thanks,
Piotr
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Flex FalconJX 0.8.0 RC1

Greg Dove
Hi Piotr,

 "If option a - mean avoid caching svg.js file - It is not a problem I know how
to do this for this file and it can be downloaded for each build."

yes, the idea here was to avoid caching the download in the
maven-download-plugin's own cache. I did not know if there was an option to
do with in the
That sounds great (at least for me, I am not concerned about the caching
aspect, but others might be)

for
" b) We are downloading this file to target/downloads/svg.js - Do you mean
changing that location and patch that file in the new location ?"

I don't mean changing the download location, but copying the downloaded
file to a separate location and patching it in a different location.
The idea is that if the maven-download-plugin is caching the file after it
has been patched (and it does seem to happen sometimes, perhaps only
rarely) from the original download location, then copying and patching it
in a different location would avoid the possibility of caching a patched
file from the original download location.

There may be other options to fix the problem I observed  Another option
might be to delay the patching of the downloaded file (maven has build
phases and I notice the patch is in 'validate', same as the download) I did
wonder if it might be possible to defer the patch to a later phase
(assuming any caching activity might then always happen first), but I do
not know enough about this.


Also it looks like we are using version 1.2.1 of the download plugin, and
current version is 1.3.0. I checked the commit history between releases and
there was at least one cache-related commit [1]. A plugin version change
might be worth considering as well, but I am not sure if it will address
the issue.

-Greg



1.
https://github.com/maven-download-plugin/maven-download-plugin/compare/1.2.1...master



On Fri, Jun 16, 2017 at 1:39 AM, piotrz <[hidden email]> wrote:

> Hi Greg,
>
> In your points "a" and "b" I'm not sure what do you mean.
>
> If option a - mean avoid caching svg.js file - It is not a problem I know
> how to do this for this file and it can be downloaded for each build.
>
> Option b) We are downloading this file to target/downloads/svg.js - Do you
> mean changing that location and patch that file in the new location ?
>
> Thanks,
> Piotr
>
>
>
> -----
> Apache Flex PMC
> [hidden email]
> --
> View this message in context: http://apache-flex-
> development.2333347.n4.nabble.com/VOTE-Release-Apache-Flex-
> FalconJX-0-8-0-RC1-tp62271p62410.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.
>
12