dual issues

classic Classic list List threaded Threaded
34 messages Options
12
Reply | Threaded
Open this post in threaded view
|

Re: dual issues

Alex Harui-2
I thought es6 wasn't always on by default?

https://thenextweb.com/dd/2016/03/09/6-reasons-need-learn-javascript-es6-no
w-not-later/#.tnw_5KKUOOPX

I haven't been paying attention so maybe all browsers are fully compliant
now?

-Alex

On 6/4/17, 12:01 AM, "Harbs" <[hidden email]> wrote:

>Not sure what you mean here.
>
>> On Jun 4, 2017, at 8:52 AM, Alex Harui <[hidden email]> wrote:
>>
>> Does FlexJS emit the right code to enable es6 APIs?
>

Reply | Threaded
Open this post in threaded view
|

Re: dual issues

Harbs
Objects like Promise, Map, Set etc. are available by default in pretty much all modern browsers.

Things like await, arrow functions, let, etc. are being added by browsers all the time. I’m not sure exactly which ones have what right now, but they are pretty far along already, so that article is already out of date. ;-)

Either way, we’re not outputting ES6-style code (currently), so those features are a non-issue.

> On Jun 4, 2017, at 10:34 AM, Alex Harui <[hidden email]> wrote:
>
> I thought es6 wasn't always on by default?
>
> https://thenextweb.com/dd/2016/03/09/6-reasons-need-learn-javascript-es6-no
> w-not-later/#.tnw_5KKUOOPX
>
> I haven't been paying attention so maybe all browsers are fully compliant
> now?
>
> -Alex
>
> On 6/4/17, 12:01 AM, "Harbs" <[hidden email]> wrote:
>
>> Not sure what you mean here.
>>
>>> On Jun 4, 2017, at 8:52 AM, Alex Harui <[hidden email]> wrote:
>>>
>>> Does FlexJS emit the right code to enable es6 APIs?
>>
>

Reply | Threaded
Open this post in threaded view
|

Re: dual issues

Harbs
In reply to this post by Harbs
Good news: Prior to the switch to dual, I was not getting a minified release build working. That’s now working.
Bad news: It takes much longer than it used to, and I’m getting a swf file even though I’m only using -targets=JSFlex

Harbs
Reply | Threaded
Open this post in threaded view
|

Re: dual issues

piotrz
Ahh..That's not good. Another thing for resolve in release definitly.

Piotr
Apache Flex PMC
piotrzarzycki21@gmail.com
Reply | Threaded
Open this post in threaded view
|

Re: dual issues

Justin Mclean
Administrator
In reply to this post by Harbs
Hi,

> Bad news: It takes much longer than it used to, and I’m getting a swf file even though I’m only using -targets=JSFlex

Compiles are also taking a lot longer for me and I’m also only using the JSFlex target.

Thanks,
Justin
Reply | Threaded
Open this post in threaded view
|

Re: dual issues

piotrz
As I remember Harbs is compiling it by ANT ? Am I right ? Justin you are compiling by Maven ?

Piotr
Apache Flex PMC
piotrzarzycki21@gmail.com
Reply | Threaded
Open this post in threaded view
|

Re: dual issues

Harbs
In reply to this post by Justin Mclean
To be clear:
Debug builds are as fast if not faster than they used to be.
Release build are much slower.

I’m getting a debug build (with remove circulars) of my (complex) app taking about 10 seconds.
The release build takes about 3 minutes.


> On Jun 4, 2017, at 11:57 AM, Justin Mclean <[hidden email]> wrote:
>
> Hi,
>
>> Bad news: It takes much longer than it used to, and I’m getting a swf file even though I’m only using -targets=JSFlex
>
> Compiles are also taking a lot longer for me and I’m also only using the JSFlex target.
>
> Thanks,
> Justin

Reply | Threaded
Open this post in threaded view
|

Re: dual issues

Justin Mclean
Administrator
In reply to this post by piotrz
Hi,

> Justin you are compiling by Maven ?

Yep and Debug builds are noticeably slower for me.

Justin
Reply | Threaded
Open this post in threaded view
|

Re: dual issues

Harbs
I’m seeing similar times using both ant and asconfig for debug. (Both are good.)

asconfig is not compiling a release build at all — even if I specify debug=false.

I have not tried with Maven.

> On Jun 4, 2017, at 12:06 PM, Justin Mclean <[hidden email]> wrote:
>
> Hi,
>
>> Justin you are compiling by Maven ?
>
> Yep and Debug builds are noticeably slower for me.
>
> Justin

Reply | Threaded
Open this post in threaded view
|

Re: dual issues

Alex Harui-2
In reply to this post by Harbs
The examples/native/ButtonExample does not produce a SWF for me, so maybe
compare that setup against yours.

HTH,
-Alex

On 6/4/17, 12:56 AM, "Harbs" <[hidden email]> wrote:

>Good news: Prior to the switch to dual, I was not getting a minified
>release build working. That’s now working.
>Bad news: It takes much longer than it used to, and I’m getting a swf
>file even though I’m only using -targets=JSFlex
>
>Harbs

Reply | Threaded
Open this post in threaded view
|

Re: dual issues

Harbs
That is using -js-output-type=FLEXJS

My understanding is that we are supposed to use -targets=JSFlex now.

Is that not right?

> On Jun 4, 2017, at 5:43 PM, Alex Harui <[hidden email]> wrote:
>
> The examples/native/ButtonExample does not produce a SWF for me, so maybe
> compare that setup against yours.
>
> HTH,
> -Alex
>
> On 6/4/17, 12:56 AM, "Harbs" <[hidden email]> wrote:
>
>> Good news: Prior to the switch to dual, I was not getting a minified
>> release build working. That’s now working.
>> Bad news: It takes much longer than it used to, and I’m getting a swf
>> file even though I’m only using -targets=JSFlex
>>
>> Harbs
>

Reply | Threaded
Open this post in threaded view
|

Re: dual issues

Alex Harui-2
For me, the Ant build calls the "compile" target in
examples/build_example.xml and sets the config_arg to use
frameworks/js-config.xml which has targets set to just JS.

A better example might be examples/flexjs/MDLExample.  For Ant, it has a
src/main/config/compile-app-config.xml which specifies:
        <targets><target>JSFlex</target></targets>

And for me, no SWF is produced.


HTH,
-Alex

On 6/4/17, 10:31 AM, "Harbs" <[hidden email]> wrote:

>That is using -js-output-type=FLEXJS
>
>My understanding is that we are supposed to use -targets=JSFlex now.
>
>Is that not right?
>
>> On Jun 4, 2017, at 5:43 PM, Alex Harui <[hidden email]> wrote:
>>
>> The examples/native/ButtonExample does not produce a SWF for me, so
>>maybe
>> compare that setup against yours.
>>
>> HTH,
>> -Alex
>>
>> On 6/4/17, 12:56 AM, "Harbs" <[hidden email]> wrote:
>>
>>> Good news: Prior to the switch to dual, I was not getting a minified
>>> release build working. That’s now working.
>>> Bad news: It takes much longer than it used to, and I’m getting a swf
>>> file even though I’m only using -targets=JSFlex
>>>
>>> Harbs
>>
>

Reply | Threaded
Open this post in threaded view
|

Re: dual issues

Josh Tynjala
In reply to this post by Harbs
Are you setting debug in an argument passed to asconfigc, like this?

asconfigc --debug=false

Or is it specified in asconfig.json in the compilerOptions section?

Both will work, but the asconfigc command line option will always override
whatever is in asconfig.json. In VSCode, the generated tasks.json now
defaults to --debug=true, so that could take precedence if you're trying to
set debug to false in asconfig.json. You might want to double-check both
locations (asconfig.json and tasks.json).

- Josh

On Sun, Jun 4, 2017 at 2:08 AM, Harbs <[hidden email]> wrote:

> I’m seeing similar times using both ant and asconfig for debug. (Both are
> good.)
>
> asconfig is not compiling a release build at all — even if I specify
> debug=false.
>
> I have not tried with Maven.
>
> > On Jun 4, 2017, at 12:06 PM, Justin Mclean <[hidden email]>
> wrote:
> >
> > Hi,
> >
> >> Justin you are compiling by Maven ?
> >
> > Yep and Debug builds are noticeably slower for me.
> >
> > Justin
>
>
Reply | Threaded
Open this post in threaded view
|

Re: dual issues

Harbs
In compilerOptions.

Here’s my tasks.json file:
{
        // See https://go.microsoft.com/fwlink/?LinkId=733558
        // for the documentation about the tasks.json format
        "version": "0.1.0",
        "command": "asconfigc",
        "isShellCommand": true,
        "args": [
                "--flexHome=/FlexSDK/FlexJSNightly"
        ],
        "windows": {
        "args": [
                        "--flexHome=C:\\dev\\flexjs_builds\\nightly_07"
                ]
    },
        "showOutput": "always"
}

asconfig.json:
{
    "config": "flex",
    "compilerOptions": {
        "debug": true,
        "targets": ["JSFlex"],
        "source-map": false,
        "library-path": [
            "lib"
        ],
        "external-library-path": [
        "typedefs"
        ]
    },
    "copySourcePathAssets": true,
    "additionalOptions": "-remove-circulars -js-output-optimization=skipAsCoercions -html-template=src/resources/mdl-js-index-template.html -js-external-library-path+=typedefs -js-library-path+=lib",
    "files":
    [
        "src/PortedPrintUI.mxml"
    ]
}

I’m having other issues after switching to dual as well. Maybe I should show you…

Harbs

> On Jun 5, 2017, at 4:31 PM, Josh Tynjala <[hidden email]> wrote:
>
> Are you setting debug in an argument passed to asconfigc, like this?
>
> asconfigc --debug=false
>
> Or is it specified in asconfig.json in the compilerOptions section?
>
> Both will work, but the asconfigc command line option will always override
> whatever is in asconfig.json. In VSCode, the generated tasks.json now
> defaults to --debug=true, so that could take precedence if you're trying to
> set debug to false in asconfig.json. You might want to double-check both
> locations (asconfig.json and tasks.json).
>
> - Josh
>
> On Sun, Jun 4, 2017 at 2:08 AM, Harbs <[hidden email]> wrote:
>
>> I’m seeing similar times using both ant and asconfig for debug. (Both are
>> good.)
>>
>> asconfig is not compiling a release build at all — even if I specify
>> debug=false.
>>
>> I have not tried with Maven.
>>
>>> On Jun 4, 2017, at 12:06 PM, Justin Mclean <[hidden email]>
>> wrote:
>>>
>>> Hi,
>>>
>>>> Justin you are compiling by Maven ?
>>>
>>> Yep and Debug builds are noticeably slower for me.
>>>
>>> Justin
>>
>>

12